Repository navigation
Refactor: convert to idiomatic Flask application factory - #127
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 83.84% 82.39% -1.46%
==========================================
Files 13 15 +2
Lines 1374 1414 +40
==========================================
+ Hits 1152 1165 +13
- Misses 222 249 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lubomir
reviewed
Sep 10, 2026
lubomir
left a comment
Contributor
There was a problem hiding this comment.
There are some references to create_app in docs/integration.rst. Other than these nitpicks, this looks like a very solid change.
lubomir
approved these changes
Sep 11, 2026
lubomir
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_app()factory, move all module-level initialization inside itdb,login_manager,migrateintocts/extensions.pycts/_version.pyapi_v1BlueprintConfigclass and globalconfsingleton; use current_app.config at request time and explicit config parameters at setup time_sync_conf_binding()hackmanage.pyusesFlaskGroup(create_app=...)with no import-time side effectscontrib/cts.wsgicallscreate_app(config_section="ProdConfiguration")explicitly