Skip to content

Normalize Uniswap Wallet connector name (INT2-1044) - #1094

Merged
pedromcunha merged 1 commit into
mainfrom
pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain
Jul 31, 2026
Merged

Normalize Uniswap Wallet connector name (INT2-1044)#1094
pedromcunha merged 1 commit into
mainfrom
pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

No description provided.

@pedromcunha
pedromcunha requested a review from ted-palmer July 30, 2026 21:39
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
relay-sdk-demo Ready Ready Preview Jul 30, 2026 9:42pm

Request Review

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 46s —— View job


📝 Docs Drift Check — No docs impact

This PR does not touch surfaces that require a relayprotocol/relay-docs update.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 53s —— View job


Code Review

  • Gather context (diff, commit, changed files)
  • Review walletCompatibility.ts change + usages
  • Verify correctness against existing patterns

Code Review — No issues found.

Reviewed 2 files, 6 lines changed. Checked for correctness, security, error handling, and repo guidelines compliance.

The change adds uniswapwallet: 'uniswap' to NormalizedWalletName. This correctly closes a real gap: WalletChainRestricted.uniswap (line 7-9) already existed, but the raw connector uniswapwallet never mapped to the uniswap key, so in useIsWalletCompatible.ts:51 and steps.ts:30 the restriction list was never applied. The new mapping makes those chain restrictions take effect, matching the changeset description. The entry follows the exact convention of the surrounding keys (lowercased, no spaces), the patch changeset is appropriate, and there are no unrelated changes.

One minor observation (not blocking): the lookup at useIsWalletCompatible.ts:51 and steps.ts:30 is case-sensitive (NormalizedWalletName[linkedWallet.connector]), unlike address.ts:74 which lowercases via connector.toLowerCase(). This fix relies on the connector arriving exactly as uniswapwallet, which is consistent with how every existing key (phantomevm, coinbasewalletevm, etc.) already works — so it's correct given the established pattern.

@pedromcunha
pedromcunha merged commit 4ed6905 into main Jul 31, 2026
7 checks passed
@pedromcunha
pedromcunha deleted the pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain branch July 31, 2026 13:45
@pedromcunha
pedromcunha restored the pedro/int2-1044-relay-app-permits-unsupported-uniswap-origin-chain branch August 3, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants