Explaining the caveats in writing to the same key with a workaround example#3283
Open
ilianiliev-redis wants to merge 1 commit intoredis:mainfrom
Open
Explaining the caveats in writing to the same key with a workaround example#3283ilianiliev-redis wants to merge 1 commit intoredis:mainfrom
ilianiliev-redis wants to merge 1 commit intoredis:mainfrom
Conversation
andy-stark-redis
approved these changes
May 8, 2026
Contributor
andy-stark-redis
left a comment
There was a problem hiding this comment.
Couple of suggestions, but otherwise LGTM.
Comment on lines
+87
to
+89
| # If you have overlapping field names e.g. FK and PK have the same name, or both table have | ||
| # a field called "id" and may want to remove the field from the after object to prevent it | ||
| # from overwriting the PK. |
Contributor
There was a problem hiding this comment.
Suggested change
| # If you have overlapping field names e.g. FK and PK have the same name, or both table have | |
| # a field called "id" and may want to remove the field from the after object to prevent it | |
| # from overwriting the PK. | |
| # If you have overlapping field names (for example, FK and PK have the same name, or both tables have | |
| # a field called "id"), you may want to remove the field from the after object to prevent it | |
| # from overwriting the PK. |
| You can also use custom keys for the parent entity, as long as you use the same key for all jobs that write to the same Redis key. | ||
|
|
||
| {{< note >}} | ||
| In the case of using the same key for different jobs, deleting any of the entities will result in the key being remove from the target. |
Contributor
There was a problem hiding this comment.
Suggested change
| In the case of using the same key for different jobs, deleting any of the entities will result in the key being remove from the target. | |
| If you are using the same key for different jobs, deleting any of the entities will result in the key being removed from the target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explaining the caveats in writing to the same key with a workaround example
Ticket: https://redislabs.atlassian.net/browse/RDSC-5181
Note
Low Risk
Documentation-only change adding guidance for a known edge case (shared-key deletes) and an example workaround; no runtime behavior is modified.
Overview
Adds a new caveat to
data-denormalization.mdthat when multiple RDI jobs write to the same Redis key, a delete event from any source entity can remove the shared key, and links to a workaround.Introduces a new transform example doc,
redis-write-same-key.md, showing how to userow_format: full, convert deleteopcodeevents into updates, and null out fields so jobs can safelyon_update: mergeinto a shared Redis JSON document without deleting the key.Reviewed by Cursor Bugbot for commit e999b1b. Bugbot is set up for automated code reviews on this repo. Configure here.