fix(#3454): remove local-path k8s plugin refs and fix app-next tab nav by fullsend-ai-coder[bot] · Pull Request #3466 · redhat-developer/rhdh-plugin-export-overlays

fullsend-ai-coder · 2026-08-28T08:47:48Z

The dynamic-plugins.yaml files in argocd, topology, and tekton workspaces referenced backstage-plugin-kubernetes-backend-dynamic via local filesystem paths (./dynamic-plugins/dist/...) that do not exist in the RHDH container during nightly mode. The install-dynamic-plugins init container silently skipped them, causing kubernetes API 404s (topology/tekton) and NotImplementedError for apiRef{plugin.kubernetes.service} (argocd).

Additionally, the topology-app-next and tekton-app-next projects failed because NFS renders entity-page tabs as link-role elements instead of tab-role elements, so getByRole('tab') timed out.

Changes:

argocd: delete dynamic-plugins.yaml entirely; RHDH defaults
include kubernetes plugins as OCI images and the argocd metadata
provides correct appConfigExamples for auto-generation
topology: remove local-path kubernetes-backend entry; RHDH
defaults provide it via OCI
tekton: remove local-path kubernetes-backend entry; RHDH
defaults provide it via OCI
topology spec: update navigateToTopology to accept testInfo and
use getByRole('link') for the topology-app-next project
tekton helper: add clickEntityLink method using
getByRole('link') and use it in goToBackstageJanusProjectCITab
for the tekton-app-next project

Closes #3454

Post-script verification

Branch is not main/master (agent/3454-k8s-local-path-fix)
Secret scan passed (gitleaks — 66f027379459c2def101479dad6260742395064a..HEAD)
Pre-commit hooks passed (authoritative run on runner)
Tests ran inside sandbox

The dynamic-plugins.yaml files in argocd, topology, and tekton workspaces referenced backstage-plugin-kubernetes-backend-dynamic via local filesystem paths (./dynamic-plugins/dist/...) that do not exist in the RHDH container during nightly mode. The install-dynamic-plugins init container silently skipped them, causing kubernetes API 404s (topology/tekton) and NotImplementedError for apiRef{plugin.kubernetes.service} (argocd). Additionally, the topology-app-next and tekton-app-next projects failed because NFS renders entity-page tabs as link-role elements instead of tab-role elements, so getByRole('tab') timed out. Changes: - argocd: delete dynamic-plugins.yaml entirely; RHDH defaults include kubernetes plugins as OCI images and the argocd metadata provides correct appConfigExamples for auto-generation - topology: remove local-path kubernetes-backend entry; RHDH defaults provide it via OCI - tekton: remove local-path kubernetes-backend entry; RHDH defaults provide it via OCI - topology spec: update navigateToTopology to accept testInfo and use getByRole('link') for the topology-app-next project - tekton helper: add clickEntityLink method using getByRole('link') and use it in goToBackstageJanusProjectCITab for the tekton-app-next project Closes #3454

openshift-ci · 2026-08-28T08:48:01Z

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

subhashkhileri · 2026-09-03T13:40:42Z

/ok-to-test

subhashkhileri · 2026-09-03T13:40:55Z

/test ?

subhashkhileri · 2026-09-03T13:41:05Z

/test e2e-ocp-helm-nightly-pr-scoped

fullsend-ai-review · 2026-09-03T13:41:37Z

🤖 Finished Review · ✅ Success · Started 1:41 PM UTC · Completed 1:48 PM UTC

Commit: 8734a90 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $1.07

fullsend-ai-review · 2026-09-03T13:48:11Z

Review — approve

PR: #3466 — fix(#3454): remove local-path k8s plugin refs and fix app-next tab nav
Author: fullsend-ai-coder[bot] | Base: main | Commits: 4 | Files: 5

Summary

This PR fixes E2E nightly test failures caused by two independent issues:

Local filesystem paths for Kubernetes plugins — The dynamic-plugins.yaml files in the argocd, topology, and tekton workspaces referenced backstage-plugin-kubernetes-backend-dynamic (and in argocd, also the frontend plugin) via ./dynamic-plugins/dist/... paths. In nightly mode, these paths do not exist in the RHDH container, causing the install-dynamic-plugins init container to silently skip them. This resulted in NotImplementedError for argocd and Kubernetes API 404s for topology/tekton.
NFS tab rendering — The topology-app-next and tekton-app-next projects use NFS (New Frontend System), which renders entity-page tabs as <a> link elements instead of <button role="tab"> elements. The existing getByRole('tab') selectors timed out.

Correctness ✅

OCI refs match metadata exactly. All version tags in the updated dynamic-plugins.yaml files match their authoritative spec.dynamicArtifact values in workspace metadata:
- backstage-plugin-kubernetes-backend:bs_1.52.0__0.21.5 ✓
- backstage-plugin-kubernetes:bs_1.52.0__0.12.20 ✓
- backstage-community-plugin-argocd:bs_1.49.4__2.8.0 ✓
- backstage-community-plugin-argocd-backend:bs_1.49.4__1.4.0 ✓
Argocd version bumps are necessary. The old argocd OCI tags (bs_1.45.3__2.4.3 / bs_1.45.3__1.0.2) were stale — the metadata already tracks bs_1.49.4. Aligning the test config with current metadata prevents a "fix the reference type but keep the wrong version" scenario.
App-next navigation fix is correct. Both topology and tekton properly branch on testInfo.project.name to use getByRole("link") for app-next projects while preserving getByRole("tab") / clickTab() for legacy projects.
Topology plugin local path retained intentionally. ./dynamic-plugins/dist/backstage-community-plugin-topology (and tekton equivalent) remain as local paths. This is correct — the e2e-test-utils framework resolves these to OCI refs in nightly/PR modes. Only the kubernetes plugins were missing because they come from a different workspace.

Security ✅

No security concerns. Changes are limited to E2E test configuration (plugin package references) and test helper code. No credentials, secrets, or RBAC changes.

Intent & Coherence ✅

Changes are appropriately scoped to workspaces/*/e2e-tests/ (allowed modifications for E2E fixes per AGENTS.md).
Correctly targets main branch as specified in issue [fullsend] E2E: k8s-local-path -- dynamic-plugins.yaml references Kubernetes plugins via nonexistent local paths #3454.
All five affected workspaces from the issue (argocd, topology, topology-app-next, tekton, tekton-app-next) are addressed.

Style & Conventions ✅

clickEntityLink() follows the same pattern as existing clickTab() (private method, waitFor + click).
Proper TypeScript typing — TestInfo imported from @playwright/test and correctly threaded through function signatures.
Consistent destructuring and test fixture usage.

Notes

Approach diverges from issue recommendation for argocd. Issue [fullsend] E2E: k8s-local-path -- dynamic-plugins.yaml references Kubernetes plugins via nonexistent local paths #3454 recommends deleting workspaces/argocd/e2e-tests/tests/config/dynamic-plugins.yaml entirely, relying on auto-generation from metadata. The PR instead keeps the file with explicit OCI refs. This is a reasonable choice — explicit configuration provides predictability and ensures the exact pluginConfig (mountPoints, conditions) the tests depend on. The trade-off is that version tags require manual updates when the workspace metadata is bumped, but all current values are correct.

Previous run

Review — approve

Summary

This PR fixes E2E nightly test failures across three workspaces (argocd, topology, tekton) caused by two root issues:

Local-path kubernetes plugin references — dynamic-plugins.yaml files referenced backstage-plugin-kubernetes-backend-dynamic via ./dynamic-plugins/dist/ paths that don't exist in the RHDH container during nightly mode. The init container silently skipped them, causing kubernetes API 404s and NotImplementedError for apiRef{plugin.kubernetes.service}.
NFS link-role navigation — The *-app-next projects render entity-page tabs as link elements instead of tab-role elements, so getByRole('tab') timed out.

Changes Reviewed

File	Assessment
`workspaces/argocd/e2e-tests/tests/config/dynamic-plugins.yaml` (deleted)	Correct. The deleted file had hardcoded OCI refs at outdated versions (e.g., `bs_1.45.3__2.4.3`) while metadata already has `bs_1.49.4__2.8.0`. Auto-generation from metadata will use current versions and RHDH defaults provide kubernetes plugins via OCI. The remaining config files (`app-config-rhdh.yaml`, `rhdh-secrets.yaml`) are unaffected.
`workspaces/tekton/e2e-tests/tests/config/dynamic-plugins.yaml`	Correct. Removes only the local-path `kubernetes-backend-dynamic` entry. Remaining entries (kubernetes frontend OCI ref, tekton plugin local path, global header disable) are appropriate.
`workspaces/topology/e2e-tests/tests/config/dynamic-plugins.yaml`	Correct. Same targeted removal of the local-path kubernetes-backend entry. Remaining entries are appropriate.
`workspaces/tekton/e2e-tests/tests/support/tekton-support-helper.ts`	Correct. New `clickEntityLink` method mirrors the existing `clickTab` pattern with `getByRole("link")`. Properly uses `waitFor({ state: "visible" })` before clicking. The `goToBackstageJanusProjectCITab` method correctly dispatches based on `testInfo.project.name`. Good JSDoc on the new method.
`workspaces/topology/e2e-tests/tests/specs/topology.spec.ts`	Correct. `navigateToTopology` signature updated with `page` and `testInfo` parameters. All 4 callers are updated. `TestInfo` import added. The project-name conditional properly uses `getByRole("link")` for `topology-app-next` and falls back to `clickTab` for the default project.

Verification

All modifications are within the allowed workspaces/<workspace>/e2e-tests/ boundary per E2E fix conventions.
Changes match the remediation plan in issue [fullsend] E2E: k8s-local-path -- dynamic-plugins.yaml references Kubernetes plugins via nonexistent local paths #3454 exactly.
No plugin source code, CI configuration, or repository config files are modified.
The testInfo threading follows standard Playwright conventions (second callback argument).
The hardcoded project name strings ("topology-app-next", "tekton-app-next") are consistent with the existing pattern in tekton-support-helper.ts.

Verdict

No blocking findings. The changes correctly address the identified nightly failures with minimal, well-scoped modifications.

Previous run (2)

Review — approve

Summary

This PR fixes E2E nightly test failures across the argocd, topology, and tekton workspaces caused by two independent issues:

Local-path kubernetes plugin references — The dynamic-plugins.yaml files in all three workspaces referenced backstage-plugin-kubernetes-backend-dynamic via local filesystem paths (./dynamic-plugins/dist/...) that do not exist in the RHDH container during nightly mode. The init container silently skipped these, causing kubernetes API 404s and NotImplementedError for apiRef{plugin.kubernetes.service}.
NFS tab/link mismatch — The New Frontend System renders entity-page tabs as link-role elements instead of tab-role elements, so getByRole('tab') timed out in topology-app-next and tekton-app-next projects.

Analysis

Config changes (dynamic-plugins.yaml)

argocd: Entire file deleted. This is the correct approach — the RHDH container provides kubernetes plugins by default as OCI images, and the argocd workspace has proper appConfigExamples in its metadata (backstage-community-plugin-argocd.yaml and backstage-community-plugin-argocd-backend.yaml) that drive auto-generation. As a bonus, this eliminates the stale hardcoded OCI versions (bs_1.45.3__2.4.3) in favor of metadata-tracked versions (bs_1.49.4__2.8.0).
tekton: Removes only the local-path kubernetes-backend-dynamic entry. The OCI-referenced kubernetes frontend plugin and the workspace's own tekton plugin entries are preserved. Correct and minimal.
topology: Same pattern as tekton — removes only the kubernetes-backend-dynamic local path. The topology plugin's local path is preserved (the framework resolves it based on mode).

Test code changes

topology spec: navigateToTopology now accepts page and testInfo parameters and branches on testInfo.project.name === "topology-app-next" to use getByRole('link') instead of uiHelper.clickTab(). All four call sites (main test + 3 RBAC tests) are updated with the new signature. TestInfo is added to imports.
tekton helper: Adds a private clickEntityLink method (mirrors the existing clickTab pattern but uses getByRole('link')). goToBackstageJanusProjectCITab uses it for the tekton-app-next project. The tekton spec file itself is unchanged — it already passed testInfo to the helper.

Scope verification: All changes are within workspaces/*/e2e-tests/ directories, consistent with fix_category: test_fix and the repo's E2E nightly fix conventions. No plugin source code, CI configuration, or repo config files are modified.

Verdict

The changes are correct, well-scoped, and directly address both root causes identified in #3454. The config changes align with the documented metadata resolution system (auto-generation from metadata/*.yaml when no dynamic-plugins.yaml exists, RHDH defaults providing kubernetes plugins). The test code changes follow existing patterns with proper element waiting and project-name branching.

Labels: PR fixes E2E nightly test failures across multiple workspaces

rhdh-test-bot · 2026-09-03T13:57:34Z

❌ Failed E2E Tests (-w argocd -w tekton -w topology)

fullsend-ai-review · 2026-09-03T14:09:23Z

🤖 Finished Ci Diagnose · ✅ Success · Started 2:09 PM UTC · Completed 2:21 PM UTC

Commit: 8734a90 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $2.10

fullsend-ai-review · 2026-09-03T14:21:22Z

✅ CI Diagnosis — 0 of 1 curated checks failing · `b8170d3`

Verdict: All curated checks are now passing. The previously-failing ci/prow/e2e-ocp-helm-nightly-pr-scoped (diagnosed as pr_regression on c05ef22) is no longer present on the current head — the fix commit b8170d3 added OCI entries for kubernetes-backend in the argocd, tekton, and topology workspaces. The prow check has not been re-triggered on this commit yet; re-running it will verify the fix.

_{Automated CI diagnosis · updates as checks complete · not a substitute for review. For bot-authored PRs, pr_regression failures are handed to the fix agent automatically (up to 2 attempts). pre_existing failures are linked to an open PR when one already exists. A maintainer can take over any time with /fs-fix <instruction>, or stop auto-fix with /fs-fix-stop.}

subhashkhileri · 2026-09-04T09:55:40Z

/test e2e-ocp-helm-nightly-pr-scoped

fullsend-ai-review · 2026-09-04T09:56:44Z

🤖 Finished Review · ✅ Success · Started 9:56 AM UTC · Completed 10:02 AM UTC

Commit: c05ef22 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.94

Superseded by updated review

rhdh-test-bot · 2026-09-04T10:12:05Z

❌ Failed E2E Tests (-w argocd -w tekton -w topology)

openshift-ci · 2026-09-04T10:22:04Z

@fullsend-ai-coder[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ocp-helm-nightly-pr-scoped	`c05ef22`	link	false	`/test e2e-ocp-helm-nightly-pr-scoped`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

fullsend-ai-review · 2026-09-04T10:23:51Z

🤖 Finished Ci Diagnose · ✅ Success · Started 10:23 AM UTC · Completed 10:38 AM UTC

Commit: c05ef22 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $3.74

fullsend-ai-coder · 2026-09-04T10:39:37Z

🤖 Finished Fix · ✅ Success · Started 10:39 AM UTC · Completed 10:44 AM UTC

Commit: c05ef22 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.91

kubernetes-backend is disabled-by-default in RHDH, so removing the local filesystem path entries without adding OCI replacements left the plugin absent in nightly mode. Add explicit OCI entries for backstage-plugin-kubernetes-backend in all three workspaces. Restore argocd dynamic-plugins.yaml with full OCI entries since auto-generation from metadata does not include cross-workspace kubernetes dependencies. Addresses review feedback on #3466

sonarqubecloud · 2026-09-04T10:45:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fullsend-ai-review · 2026-09-04T10:45:54Z

🤖 Finished Review · ✅ Success · Started 10:45 AM UTC · Completed 10:52 AM UTC

Commit: b8170d3 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.93

Superseded by updated review

fullsend-ai-review · 2026-09-04T10:52:58Z

🤖 Finished Ci Diagnose · ✅ Success · Started 10:52 AM UTC · Completed 10:58 AM UTC

Commit: b8170d3 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.85

fullsend-ai-coder Bot requested review from a team, djanickova and dzemanov as code owners August 28, 2026 08:47

fullsend-ai-coder Bot requested review from divyanshiGupta and karthikjeeyar and removed request for a team August 28, 2026 08:47

openshift-ci Bot added the needs-ok-to-test label Aug 28, 2026

This was referenced Aug 29, 2026

[fullsend] E2E: k8s-local-path -- dynamic-plugins.yaml references Kubernetes plugins via nonexistent local paths #3454

Open

[fullsend] E2E nightly failure: main (2026-08-29) #3473

Closed

Merge branch 'main' into agent/3454-k8s-local-path-fix

8734a90

openshift-ci Bot added ok-to-test and removed needs-ok-to-test labels Sep 3, 2026

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge e2e-fix-agent Triggers the fullsend e2e-fix agent labels Sep 3, 2026

rhdh-gh-app Bot added the ci-diagnose Triggers the fullsend ci-diagnose agent label Sep 3, 2026

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot mentioned this pull request Sep 3, 2026

fix(#3437): use tooltip locator to avoid race in topology e2e #3439

Open

4 tasks

subhashkhileri mentioned this pull request Sep 3, 2026

chore: bump fullsend from v0.37.0 to v0.40.0 #3554

Closed

5 tasks

Merge branch 'main' into agent/3454-k8s-local-path-fix

c05ef22

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Sep 4, 2026

rhdh-gh-app Bot added ci-diagnose Triggers the fullsend ci-diagnose agent and removed ci-diagnose Triggers the fullsend ci-diagnose agent labels Sep 4, 2026

This comment was marked as outdated.

Sign in to view

rhdh-gh-app Bot added ci-diagnose Triggers the fullsend ci-diagnose agent and removed ci-diagnose Triggers the fullsend ci-diagnose agent labels Sep 4, 2026

fullsend-ai-review Bot approved these changes Sep 4, 2026

View reviewed changes

fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Sep 4, 2026

Uh oh!

Conversation

fullsend-ai-coder Bot commented Aug 28, 2026

Post-script verification

Uh oh!

openshift-ci Bot commented Aug 28, 2026

Uh oh!

subhashkhileri commented Sep 3, 2026

Uh oh!

subhashkhileri commented Sep 3, 2026

Uh oh!

subhashkhileri commented Sep 3, 2026

Uh oh!

fullsend-ai-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review — approve

Summary

Correctness ✅

Security ✅

Intent & Coherence ✅

Style & Conventions ✅

Notes

Review — approve

Summary

Changes Reviewed

Verification

Verdict

Review — approve

Summary

Analysis

Verdict

Uh oh!

This comment was marked as outdated.

Uh oh!

rhdh-test-bot commented Sep 3, 2026

❌ Failed E2E Tests (-w argocd -w tekton -w topology)

Uh oh!

fullsend-ai-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ CI Diagnosis — 0 of 1 curated checks failing · b8170d3

Uh oh!

This comment was marked as outdated.

Uh oh!

subhashkhileri commented Sep 4, 2026

Uh oh!

fullsend-ai-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

rhdh-test-bot commented Sep 4, 2026

❌ Failed E2E Tests (-w argocd -w tekton -w topology)

Uh oh!

openshift-ci Bot commented Sep 4, 2026

Uh oh!

fullsend-ai-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

fullsend-ai-coder Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Sep 4, 2026

Quality Gate passed

Uh oh!

fullsend-ai-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

fullsend-ai-review Bot commented Sep 3, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 3, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 3, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 3, 2026 •

edited

Loading

✅ CI Diagnosis — 0 of 1 curated checks failing · `b8170d3`

fullsend-ai-review Bot commented Sep 4, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 4, 2026 •

edited

Loading

fullsend-ai-coder Bot commented Sep 4, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 4, 2026 •

edited

Loading

fullsend-ai-review Bot commented Sep 4, 2026 •

edited

Loading