feat(secrets): add unified Bitwarden secret runner - #157
Merged
subhashkhileri merged 8 commits intoSep 10, 2026
Conversation
Assisted-by: OpenCode
Assisted-by: OpenCode
Assisted-by: OpenCode
Assisted-by: OpenCode
zdrapela
force-pushed
the
feat/bitwarden-local-secrets
branch
from
September 9, 2026 15:04
b842b71 to
d86a871
Compare
zdrapela
marked this pull request as ready for review
September 9, 2026 15:05
Keep provider credentials out of spawned test processes without mutating Playwright's process environment during global setup. Assisted-by: OpenCode Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
Allow local .env values to override inherited secrets while preserving CI environment precedence. Assisted-by: OpenCode Signed-off-by: Zbyněk Drápela <zbynek.drapela@gmail.com>
| process.env.KEYCLOAK_METADATA_URL = `${keycloak.keycloakUrl}/realms/${realm}`; | ||
| process.env.KEYCLOAK_BASE_URL = keycloak.keycloakUrl; | ||
|
|
||
| console.table({ |
Member
There was a problem hiding this comment.
this info was helpful to know what key-cloak credentials are when testing locally. either to login to rhdh or keycloak itself for debugging
Member
Author
There was a problem hiding this comment.
Okay, I can put that back
Assisted-by: OpenCode
Assisted-by: OpenCode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
secretsexport with profile parsing, collection mapping, Bitwarden access, environment materialization, and child-process execution.rhdh-e2e-secrets execCLI for running commands with selected secrets.bwexecutable.VAULT_*environment naming contract through profile transforms.bw get attachment ... --raw.nullor empty-string notes, and command failures do not expose payload contents.2.3.0.Why the locally installed
bwCLIThe runner invokes the locally installed Bitwarden
bwexecutable instead of adding the NPM@bitwarden/clipackage. The NPM CLI requires a specific Node.js version, which would conflict with Node.js versions selected by the E2E toolchain and CI and would add unnecessary runtime coupling to every consumer. Using the external CLI keeps the package dependency graph stable while allowing the same secret-management flow to be used by bothrhdh-plugin-export-overlaysandrhdh.The runner does not log in, unlock, lock, or persist the Bitwarden session. It only uses the existing
BW_SESSIONvalue and the installed CLI.Consumer
The corresponding overlay integration is in rhdh-plugin-export-overlays#3565.
This package is intended to be the shared secret-management tool for E2E execution across both
rhdh-plugin-export-overlaysandrhdhrepositories.Validation
Dependency
The overlay consumer must wait for the
2.3.0package release before registry-based installs can resolve it.