Repository navigation
allow passing custom fields to BrainTree's rules manager - #998
clarkstuth wants to merge 2 commits into
Conversation
cbarton
left a comment
cbarton
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Had a suggestion on the new configuration location before adopting.
| * @see {@link https://developer.paypal.com/braintree/docs/guides/3d-secure/rules-manager/javascript/v3/#custom-fields} | ||
| */ | ||
| get customFields () { | ||
| return this.threeDSecure.recurly.config.risk.threeDSecure.proactive.customFields; |
There was a problem hiding this comment.
I think that we should store this on this.threeDSecure.recurly.config.risk.threeDSecure given attach runs for both proactive and reactive.
There was a problem hiding this comment.
Thanks for the review @cbarton, I've made the suggested config change.
41c09f5 to
61cfc16
Compare
| * @see {@link https://developer.paypal.com/braintree/docs/guides/3d-secure/rules-manager/javascript/v3/#custom-fields} | ||
| */ | ||
| get customFields () { | ||
| return this.threeDSecure.recurly.config.risk.threeDSecure.customFields; |
There was a problem hiding this comment.
I apologize, we discussed this internally and my previous comment was partially incorrect, we want this nested under config.risk.threeDSecure.braintree.customFields to mirror the other settings, like config.fraud.braintree....
Once that change is made, we can move forward with merging and including this in the next release.
2 participants
Hi Recurly Team,
I'm improving my organization’s 3D Secure implementation and running into a small feature gap in how recurly-js communicates with the Braintree client.
Braintree’s Control Panel lets you create “Merchant-Defined Custom Fields.” The Rules Manager can use these custom fields to determine whether 3D Secure should trigger for a transaction. link to Braintree's docs
To pass these custom fields to Braintree, they must be part of the
verifyCard()call on the Braintree client. As it currently stands, recurly-js doesn't provide a way to pass these custom fields.I have taken a stab at connecting the dots so that I can pass these custom fields along to Braintree. It would be super helpful to have this ported into recurly-js.
Thanks in advance!