Repository navigation
Conversation
acessMode, exemption, feature, and hazard can now be expressed as string|string[]
JayPanoz
requested review from
HadrienGardeur
and
a lite review from Copilot
September 14, 2026 10:43
There was a problem hiding this comment.
馃煝 Approval recommended
Only minor documentation nits remain; no blocking issues were identified.
Pull request overview
Updates accessibility metadata schemas and documentation to support scalar or array values.
Changes:
- Adds reusable schema definitions.
- Supports string or string-array values for selected accessibility properties.
- Updates documentation and examples.
File summaries
| File | Summary |
|---|---|
schema/a11y.schema.json |
Adds scalar-or-array validation for accessibility metadata. |
contexts/default/README.md |
Documents the expanded value forms and updates examples. |
Review details
Suppressed comments (1)
contexts/default/README.md:422
- This updated sentence is missing an article:
focused on listshould readfocused on a list.
While `accessMode` provides a complete list, `accessModeSufficient` is focused on list of single or combined accessModes that are sufficient to understand all the intellectual content of a resource. `accessMode` can be expressed as a single value or an array of values.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
FYI this shipped in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accessMode,exemption,feature, andhazardcan now be expressed asstring|string[]cc @mickael-menu this change should roll out in the next version of TS-Toolkit鈥檚
shared, but that means it impacts mobile toolkits as well.