4.0.0-alpha.1 - #889
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the toolkit for the 4.0.0-alpha.1 prerelease by bumping version strings across the Test App, CocoaPods specs/podspecs, and documentation, while updating the release tooling and documentation pipeline to properly handle prereleases.
Changes:
- Bump version references to
4.0.0-alpha.1across CocoaPods specs/podspecs, README, Test App Info.plist, changelog, and migration guide. - Update release scripts to support prerelease SemVer parsing, safer tag/branch handling, and GitHub prerelease publishing.
- Update the documentation workflow to deploy versioned docs for tags while keeping
latesttied to stable releases.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TestApp/Sources/Info.plist | Bumps app version/build identifiers to 4.0.0-alpha.1. |
| Support/CocoaPods/Specs.swift | Updates shared CocoaPods version constant used to generate podspecs. |
| Support/CocoaPods/ReadiumStreamer.podspec | Bumps pod version and dependency constraint to prerelease. |
| Support/CocoaPods/ReadiumShared.podspec | Bumps pod version to prerelease. |
| Support/CocoaPods/ReadiumOPDS.podspec | Bumps pod version and dependency constraint to prerelease. |
| Support/CocoaPods/ReadiumNavigator.podspec | Bumps pod version and dependency constraint to prerelease. |
| Support/CocoaPods/ReadiumLCP.podspec | Bumps pod version and dependency constraint to prerelease. |
| Sources/OPDS/OPDSParser.swift | Adds an unavailable completion-handler API to steer users to async parseURL. |
| scripts/release-tag.sh | Extends version extraction and makes tag push more robust with explicit refspec and local-tag checks. |
| scripts/release-prepare.sh | Adds preflight tag checks and changes release branch naming/refspec to avoid tag/branch ambiguity. |
| scripts/release-md-tools.py | Improves changelog section extraction and avoids inserting Minimum Requirements rows for prereleases. |
| scripts/release-github.sh | Marks prereleases with gh release create --prerelease so stable remains “Latest”. |
| scripts/release-common.sh | Extends SemVer validation for prerelease suffixes and adds is_prerelease. |
| README.md | Updates minimum requirements and CocoaPods installation snippets to 4.0.0-alpha.1. |
| MAINTAINING.md | Documents prerelease behavior and clarifies release workflow constraints. |
| docs/Migration Guide.md | Starts a 4.0.0-alpha.1 section and preserves “Unreleased” heading as a comment. |
| CHANGELOG.md | Adds 4.0.0-alpha.1 release entry and comparison link; comments out Unreleased heading. |
| .github/workflows/docs.yml | Adjusts docs deployment logic to treat prereleases differently (versioned only; stable keeps latest). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lauripaloahde
pushed a commit
to aanel-fi/swift-toolkit
that referenced
this pull request
Aug 24, 2026
The swept invariant test pinned `insetTop`/`insetBottom` at 60/60, which is the FIRST/LAST resource geometry. `aanelContinuousInsets` zeroes both insets on every INTERIOR resource — and interior resources are exactly the chapters the centring fix is about — so the sweep only ever exercised the geometry where the margin is comfortable, and never the tight one. Sweep all four geometries instead (interior, first, last, single-resource), and drop `insetBottom` from the asserted margin, since on an interior resource it contributes nothing: the whole margin there is `viewportHeight / 4`. `aanelCentredYOffset`'s doc comment said "at least viewportHeight / 4 + insetBottom", which is true but loose enough to be read as if insetBottom were always available; it now says so. Found in review of aanel PR readium#889. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.