Add the CSS selector to the selection returned by the EPUB navigator - #817
Draft
mickael-menu wants to merge 1 commit into
Draft
mickael-menu wants to merge 1 commit into
mickael-menu wants to merge 1 commit into
Conversation
The Locator returned by SelectableNavigator.currentSelection() now includes the cssSelector of the element containing the selection in its locations, allowing apps to robustly anchor highlights and annotations. The selector is computed in the JavaScript layer with css-selector-generator from the selection range's common ancestor element, and exposed through the existing Locator.Locations.cssSelector extension. Any cssSelector inherited from the current locator is stripped so the key is never stale. Fixes #704 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Locatorreturned bySelectableNavigator.currentSelection()in the EPUB navigator now includes thecssSelectorof the element containing the selection in itslocations, allowing apps to robustly anchor highlights and annotations.The selector is computed in the JavaScript layer with
css-selector-generator(same pattern asfindFirstVisibleLocator) from the selection range's common ancestor element, and exposed through the existingLocator.Locations.cssSelectorextension. AnycssSelectorinherited from the current locator is stripped so the key is never stale. The JS bundles were regenerated withmake scripts.The property name stays
cssSelector, consistent with the toolkit's existing conventions, so a future readium/annotations implementation (W3CCssSelector) can map it directly.Fixes #704
🤖 Generated with Claude Code