[0.2.x] Support Promise v3#116
Merged
Merged
Conversation
WyriHaximus
force-pushed
the
0.2.x-promise-v3
branch
6 times, most recently
from
854dfcc to
b6f1aed
Compare
Brings support for Promise v3 to the filesystem package.
WyriHaximus
force-pushed
the
0.2.x-promise-v3
branch
from
b6f1aed to
ea6211d
Compare
|
Great! Any plans on when this will be available on packagist? |
clue
approved these changes
Mar 26, 2024
clue
left a comment
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus I don't think this is currently tested in our test matrix because this project still contains a composer.lock with Promise v2, but if you confirm this is tested, I think this is good to go 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings support for Promise v3 to the filesystem package.