fix: allow draggable modal to work with inline left style #1056#1077
Open
fluxaro wants to merge 1 commit intoreactjs:masterfrom
Open
fix: allow draggable modal to work with inline left style #1056#1077fluxaro wants to merge 1 commit intoreactjs:masterfrom
fluxaro wants to merge 1 commit intoreactjs:masterfrom
Conversation
diasbruno
reviewed
Apr 17, 2026
| }, | ||
| "scripts": { | ||
| "start": "npx webpack-dev-server --config ./scripts/webpack.config.js --inline --host 127.0.0.1 --content-base examples/", | ||
| "start": "set NODE_OPTIONS=--openssl-legacy-provider && npx webpack-dev-server --config ./scripts/webpack.config.js --inline --host 127.0.0.1 --content-base examples/", |
diasbruno
reviewed
Apr 17, 2026
| import DraggableModal from "./components/DraggableModal"; | ||
|
|
||
| export default Modal; | ||
| export { DraggableModal }; |
Collaborator
There was a problem hiding this comment.
DraggableModal shouldn't be exported by this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This fixes the issue where draggable modals stop working when an inline
left: 0style is applied (Issue #1056).How it was fixed
leftis set inline.Testing
left: 0.leftvalues.