chore(package): add package.json as an export#1670
Open
clementprevot wants to merge 1 commit intoreact-hookz:masterfrom
Open
chore(package): add package.json as an export#1670clementprevot wants to merge 1 commit intoreact-hookz:masterfrom
clementprevot wants to merge 1 commit intoreact-hookz:masterfrom
Conversation
Storybook browse dependencies looking for some Storybook dedicated meta in the package.json file. But as @react-hooks/web does not export its package.json file, Storybook spits a warning > unable to find package.json for @react-hookz/web Adding this export solves this warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior, and the steps to reproduce the issue?
When using @react-hookz/web in a component library (like a design system) that uses Storybook, Storybook browses dependencies looking for some dedicated meta in each dependency "package.json" file (
storybookfield).But as @react-hooks/web does not export its "package.json" file, Storybook spits the following warning:
Its not really an issue, more an annoyance.
What is the expected behavior?
Storybook has access to @react-hooks/web's "package.json" file.
How does this PR fix the problem?
Simply by adding "package.json" as an export of itself :-)
Checklist