RM-9724 Add FocrceSeek to lockstatment for Batched Sql queries - #1446
Open
dkudernatsch wants to merge 2 commits into
Open
RM-9724 Add FocrceSeek to lockstatment for Batched Sql queries#1446dkudernatsch wants to merge 2 commits into
dkudernatsch wants to merge 2 commits into
Conversation
MichaelKetting
approved these changes
Aug 17, 2026
| { | ||
| var selectColumns = string.Join(", ", columns.Select(c => $"{parameterAlias}.{c}")); | ||
| var joinCondition = string.Join(" AND ", columns.Select(c => $"{parameterAlias}.{c} = {tableAlias}.{c}")); | ||
| var tableHints = forReadCommittedIsolation ? "ROWLOCK, XLOCK, READPAST" : "ROWLOCK, XLOCK"; |
Member
There was a problem hiding this comment.
I think we should update the Lock_DoesNotWaitToFail_ForOtherTransaction_WithIsolationLevel_ReadCommitted to use more than two Tasks and possibly switch from Task to Thread. It doesn't have to be in this PR but it would be correct and helpful to demonstrate the issue. If not done here, we need a follow-up task.
dkudernatsch
force-pushed
the
bugfix/RM-9724
branch
from
August 18, 2026 08:13
88092b5 to
2c7beb6
Compare
MichaelKetting
approved these changes
Aug 25, 2026
MichaelKetting
left a comment
MichaelKetting
left a comment
Member
There was a problem hiding this comment.
See comment about test. Please do a rebase on top of devleop to get rid of the forward merge. Note: I updated the branch rules to enforce a title. Not sure if this breaks force push for the current branch. During Merge, it's possible github allows a custom message. if so, please amend the branchname printed inthe commit message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.