[Data] Modify maximum memory to OOM prevention docs - #65509
Open
viiccwen wants to merge 2 commits into
Open
Conversation
Signed-off-by: viiccwen <vicwen@apache.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation on avoiding out-of-memory (OOM) errors in Ray Data by recommending that users set the memory parameter to 1.25 times (or 125% of) the maximum observed heap memory. The feedback suggests clarifying the reference to max_uss_bytes by explicitly pointing out that users should look at the 'max' key within this dictionary to avoid ambiguity.
Signed-off-by: viiccwen <vicwen@apache.org>
Contributor
Author
|
Hello @bveeramani, it's can be reviewed, PTAL. Thanks! |
ray-gardener
Bot
added
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Ray Data OOM prevention guide to recommend setting
memoryto 125% of the maximum observed worker heap memory. This leaves a 20% buffer for variation between jobs and future increases in memory use.Related issues
closes #65508.
Additional information