[Docs][KubeRay] Use RayJob sample YAML for History Server docs - #65505
[Docs][KubeRay] Use RayJob sample YAML for History Server docs#65505win5923 wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the KubeRay History Server user guide to deploy an example RayJob instead of a RayCluster with the collector sidecar, updating the manifests, environment variables, verification steps, and storage layouts accordingly. The review feedback points out an inaccuracy regarding the explanation of shutdownAfterJobFinishes and ttlSecondsAfterFinished and suggests a correction to accurately describe when the underlying RayCluster and the RayJob resource are deleted.
Signed-off-by: win5923 <ken89@kimo.com>
b1175b4 to
b58bf1d
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Jun-Hao Wan <ken0979172817@gmail.com>
|
Please add DCO |
…er.md Co-authored-by: Nary Yeh <60069744+machichima@users.noreply.github.com> Signed-off-by: Jun-Hao Wan <ken0979172817@gmail.com>
| Check the RayJob status. The entrypoint script takes about a minute to finish: | ||
|
|
||
| ```sh | ||
| kubectl get rayjob ${RAY_JOB} |
There was a problem hiding this comment.
I don't think we have this env var (RAY_JOB)?
There was a problem hiding this comment.
It's exported in line 127
machichima
left a comment
machichima
left a comment
There was a problem hiding this comment.
Overall LGTM, just above two comments. Thank you!
Co-authored-by: Nary Yeh <60069744+machichima@users.noreply.github.com> Signed-off-by: Jun-Hao Wan <ken0979172817@gmail.com>
ray-gardener
Bot
added
docs
2 participants
Description
Update the Ray History Server with KubeRay doc to use RayJob example, this is related to ray-project/kuberay#5150
Related issues
Additional information