Skip to content

bug(ui,gh pages): deep linking not working with gh pages hash routes #688

Description

@johallar

Summary

gh pages doesn't work with the hash urls used for gh pages:
https://rapidsai.github.io/quent/simulator/#/profile/engine/01a07b4c-86ab-7971-97c1-24879c41910e/query/01a07b4c-86ab-7971-97c1-28ffb10dde0d/timeline

Clicking the share button

Version / commit

main

Recreation / reproduction steps

  1. Open stable link to query engine UI: https://rapidsai.github.io/quent/simulator/#/profile/engine/01a07b4c-86ab-7971-97c1-24879c41910e/query/01a07b4c-86ab-7971-97c1-28ffb10dde0d/timeline
  2. Select an operator, change tabs, etc
  3. Generate link by clicking the "share" button in upper right and paste into new tab
  4. See this takes you back to root path

Expected behavior

Link generation needs to leave hash urls intact

UI details

Generated urls like:
https://rapidsai.github.io/quent/simulator/?s=v2.H4sIAAAAAAACA42QwU7DMAyG38XnBcVRtjR9g10rboiDm7ijUpeUNhWMqe-OWwFHNJ9sy7__z77DlJfCUN-B06VPfI5Qg0bSrrVBVSdqlfMOlXcBlbGV88GiR81wgPeFp9v_gqrrWtQxso4iKNTKcOmvPIgVrNL5zQXgK-drQ-myF3OhqUCtD8IlDvrpaBCN9Ser98BV1DMPHEqf06YYB0p_MJU5dsr7DSawUWQwKhusZ3R0osps3hPPeZkCz_v1nyOlyLHJH-conZfHnvAqa3Iuzc-q59so9BDeKCUeYF2_AY_JatBgAQAA

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinguiPertains to the UI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions