Repository navigation
[PR] no-engine refusal: one line — requires Node.js 22+ - #5326
Open
ranxianglei wants to merge 3 commits into
Open
ranxianglei wants to merge 3 commits into
ranxianglei wants to merge 3 commits into
Conversation
This was referenced Oct 31, 2026
Closed
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.7466-pr.5326.7d6cb7cThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5326.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复——镜像全文检索(no-engine / Node.js 22 / SQLite engine hint)无其他 issue/PR 涉及同一主题;本 PR(GitHub #5326)即该定调的唯一工作项。 审核结论:可合入独立验证证据(全部在「当前 master f6e69ae + PR head c592548」的合并树上实测,非照抄 PR 描述):
结构化八问:
行为变更披露(旧值→新值 + 原因):
测试有效性:新增断言有牙——删掉新分支或给它加平台门都会红;负方向(该静默的仍静默)保留;22.5 门槛正反两侧都有钉。真测试。 判定:可合入。唯一红(unused-exports)为 master 继承,不拦本 PR;建议合并前顺手 merge 一次 master。 |
ranxianglei
pushed a commit
that referenced
this pull request
Oct 31, 2026
… of intent, #5222/#5326) - web surfaces (client/i18n/page/admin): take master's merged #5322 detector surface; drop this branch's parallel dns-wedge-banner implementation — one alarm state, one rendered surface. - resolver-wedge.ts + test: keep this branch's superset (FIFO cap MAX_TRACKED_HOSTS=256 against user-supplied host growth). - tunnel-guard.ts: union — main-pool verdict recorded BEFORE the worker stage (a worker-rescued admission still counts as wedge evidence, #5326 coupling) + immediate getResolverWedgeState() eval on failure preserved from #5322 (warn log fires at trip moment, not next status poll). - tests/resolver-wedge.test.ts: workerFallback:false on the checkTunnelDestination scenario keeps it hermetic with the worker stage in.
This was referenced Oct 31, 2026
ranxianglei
pushed a commit
that referenced
this pull request
Nov 1, 2026
…cannot start (#5326 follow-up per owner) The DSH lane auto-spawns its own bili proxy; when Node.js lacks the built-in SQLite engine (<22) the process refuses to start and the embedded panel used to show the generic 'run /acp first' degraded hint — wrong advice for this failure. Now the host half classifies the bootstrap failure and publishes it on the __BILI__ snapshot while no proxy is bound; the panel shows the Node.js-upgrade text (zh/en) for kind no-engine, unchanged for anything else.
ranxianglei
pushed a commit
that referenced
this pull request
Nov 11, 2026
…cannot start (#5326 follow-up per owner) The DSH lane auto-spawns its own bili proxy; when Node.js lacks the built-in SQLite engine (<22) the process refuses to start and the embedded panel used to show the generic 'run /acp first' degraded hint — wrong advice for this failure. Now the host half classifies the bootstrap failure and publishes it on the __BILI__ snapshot while no proxy is bound; the panel shows the Node.js-upgrade text (zh/en) for kind no-engine, unchanged for anything else.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
报错文案:SQLite 引擎缺失时只说一句"需要 Node.js 22+"
背景:裁决③④⑤之后,索引库打不开一律拒绝启动并给修复指引(不再静默降级)。但"没有可用 SQLite 引擎"这一类(Node < 22 且 better-sqlite3 未装)原来的提示要么为空、要么夹在大段策略说明里,用户抓不到重点。owner 定调:这个报错只需要说需要 Node.js 22 以上。
改动(全部用户可见措辞统一为同一句:
requires Node.js 22 or newer)src/storage/shadow.ts:sqliteOpenFailureHint()新增唯一一条跨平台分支no SQLite engine available → requires Node.js 22 or newer;拒绝启动日志行最终形如…REFUSING TO START (…)to serve JSON-only; requires Node.js 22 or newer。其余不变(win32 readonly/CANTOPEN 长提示照旧)。src/server.ts:boot 拒启日志行原来给裸错误无任何指引,现同带该提示。src/storage/engine-bootstrap.ts:旧措辞node:sqlite needs Node.js >= 22.5的nodeSqliteUpgradeHint()统一为Node.js 22 or newer(内部判定阈值仍是真实的 22.5,只改展示文案)——此前同一故障有"22 or newer"与">= 22.5"两套话并存,现在全局一句。/__bili/status的 degradeReason 走同一函数,自动带上这句。测试
关联:#4343(Node 20 bootstrap 故障史)、#5213 落地后的拒绝启动消息体系。