Skip to content

[PR] docs(#5313): seed the two BILI_* names the lifecycle ledger guard reads from src - #5314

Closed
Louie0806 wants to merge 1 commit into
ranxianglei:masterfrom
Louie0806:2026-10-31_ledger-seed-two-names
Closed

Louie0806 wants to merge 1 commit into
ranxianglei:masterfrom
Louie0806:2026-10-31_ledger-seed-two-names

Conversation

@Louie0806

Copy link
Copy Markdown
Contributor

(ai: deepseek/deepseek-v41-flash)

Why

lifecycle-ledger-guard is a required check and it is red on master itself, so it is red on every branch that merges master:

FAIL: 2 BILI_* env var(s) read from src/ but NOT in LIFECYCLE.md:
  - BILI_SESSION_CONTENT_STORE_PIN
  - BILI_SPAWN_FINGERPRINT

Both reads are legitimate and already documented at their definition sites; only the ledger rows are missing. This PR adds them. Filed as #5313.

Because the gate is red on master, reviewers currently cannot use it to distinguish "this branch broke something" from "master was already broken" — and it is concretely blocking unrelated fixes: #4785 (the draftTailKind one-word fix that closes #4764, the <summary> draft-envelope root cause) fails this job on BILI_SESSION_CONTENT_STORE_PIN alone (job 124424975017).

Changes

LIFECYCLE.md, two table rows, no code:

row section read at
BILI_SPAWN_FINGERPRINT §2.2 internal spawn channel, after BILI_LAUNCHER_LANE src/instance.ts:308 SPAWN_FINGERPRINT_ENV
BILI_SESSION_CONTENT_STORE_PIN §2.4 session pool / GC / persistence, after BILI_SESSION_RESIDENT_HARD_MAX_BYTES src/knobs.ts:444 contentStorePinned()

Verification

gate result
node scripts/lifecycle-ledger-guard.mjs OK: every BILI_* env var read from src/ is registered in LIFECYCLE.md (171 read / 174 ledger / 16 §3 exempt)
negative control: check out upstream/master -- LIFECYCLE.md same command re-reports both names — the assertion is not loosened
node tools/gen-config-docs.mjs generate + git diff --exit-code exit 0 (docs-sync clean)
node tools/gen-config-docs.mjs check-coverage coverage ok: 193 env names + 59 top-level keys
node scripts/config-surface-guard.mjs config-surface coverage OK
node scripts/check-unused-exports.mjs clean (6 waived)
npx tsc --noEmit clean

No existing open PR fixes this. The only other open PR touching LIFECYCLE.md is #5309 (the BILI_DSH_MAX_TESTED_VERSION row) — different section, different line, no conflict.

Same shape as two prior docs-only incidents: 6932ab48c (#2222 → BILI_CODEX_STATE_MODE) and afd6287de (#4308 follow-up).

Closes #5313.

…uard reads from src

`lifecycle-ledger-guard` fails on master head a34a65a with

  FAIL: 2 BILI_* env var(s) read from src/ but NOT in LIFECYCLE.md:
    - BILI_SESSION_CONTENT_STORE_PIN
    - BILI_SPAWN_FINGERPRINT

Both reads are legitimate and already documented at their definition site:

* src/instance.ts:308 SPAWN_FINGERPRINT_ENV — ranxianglei#4125 hands the spawner's entry
  script digest to the child so a rotate/attach gate never judges one side's
  digest against the other side's twin; a malformed or absent value falls back
  to a local re-hash.
* src/knobs.ts:444 contentStorePinned — ranxianglei#4788 phase 2 pins a session's CCR
  content store resident instead of folding it away after the save lands.

Neither was registered, so the guard reds every branch that merges master —
including this PR, whose own change has nothing to do with either knob. Same
shape as cadbf77: a doc-only seeding fix that restores the gate's meaning as
a merge signal.

Verified locally: lifecycle-ledger-guard OK (171 read / 174 ledger / 16 exempt),
unused-export clean (6 waived), config-surface OK, tsc clean, build OK.
@ranxianglei

Copy link
Copy Markdown
Owner

关单说明:本 PR 的内容(LIFECYCLE.md 补 BILI_SPAWN_FINGERPRINT / BILI_SESSION_CONTENT_STORE_PIN 两行登记)已由 #5327 逐字并入 master(f9cec9f),lifecycle-ledger-guard 随之转绿。留它只会冲突白烧 CI。—— 由 #5327 交付方代为关闭。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants