Repository navigation
Conversation
…uard reads from src `lifecycle-ledger-guard` fails on master head a34a65a with FAIL: 2 BILI_* env var(s) read from src/ but NOT in LIFECYCLE.md: - BILI_SESSION_CONTENT_STORE_PIN - BILI_SPAWN_FINGERPRINT Both reads are legitimate and already documented at their definition site: * src/instance.ts:308 SPAWN_FINGERPRINT_ENV — ranxianglei#4125 hands the spawner's entry script digest to the child so a rotate/attach gate never judges one side's digest against the other side's twin; a malformed or absent value falls back to a local re-hash. * src/knobs.ts:444 contentStorePinned — ranxianglei#4788 phase 2 pins a session's CCR content store resident instead of folding it away after the save lands. Neither was registered, so the guard reds every branch that merges master — including this PR, whose own change has nothing to do with either knob. Same shape as cadbf77: a doc-only seeding fix that restores the gate's meaning as a merge signal. Verified locally: lifecycle-ledger-guard OK (171 read / 174 ledger / 16 exempt), unused-export clean (6 waived), config-surface OK, tsc clean, build OK.
This was referenced Oct 31, 2026
Closed
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(ai: deepseek/deepseek-v41-flash)
Why
lifecycle-ledger-guardis a required check and it is red on master itself, so it is red on every branch that merges master:Both reads are legitimate and already documented at their definition sites; only the ledger rows are missing. This PR adds them. Filed as #5313.
Because the gate is red on master, reviewers currently cannot use it to distinguish "this branch broke something" from "master was already broken" — and it is concretely blocking unrelated fixes: #4785 (the
draftTailKindone-word fix that closes #4764, the<summary>draft-envelope root cause) fails this job onBILI_SESSION_CONTENT_STORE_PINalone (job124424975017).Changes
LIFECYCLE.md, two table rows, no code:BILI_SPAWN_FINGERPRINTBILI_LAUNCHER_LANEsrc/instance.ts:308SPAWN_FINGERPRINT_ENVBILI_SESSION_CONTENT_STORE_PINBILI_SESSION_RESIDENT_HARD_MAX_BYTESsrc/knobs.ts:444contentStorePinned()BILI_SPAWN_FINGERPRINT([Bug] Plugin bootstrap spawns a new instance while the old one still holds the port and drops proxying (goes direct): la | [Bug] 插件 bootstrap 在旧实例仍占端口时新起实例并放弃代理(goes direct):大会话随即以未压缩历史撞上游上限(400 Range of input length / 413) #4125, merged as [PR] Two installations differing by one version no longer deadlock on the same port; traffic is no longer sent in the clear ( | 两份安装差一个版本不再死锁在同一端口上,流量不再裸奔(#4125) #5303): the spawner passes its entry-script sha256 to the child so a rotate/attach gate never judges one side's digest against the other side's twin; a malformed or absent value falls back to a local re-hash.BILI_SESSION_CONTENT_STORE_PIN([Performance] v0.1.208 long sessions exceed 2 GiB memory and spend 14–22 seconds in local processing #4788 phase 2):=1/truekeeps a session's CCR content store ({byRef}/{byHash}originals) resident in memory instead of folding it away after the save lands; re-materialises from the unified ccr mirror or the.content-store.jsonsidecar on first touch (payload-first write order, CCR content-store companion write is non-atomic — a crash mid-write silently destroys all retrievable originals #2674). Unset /0/false= fold (default).Verification
node scripts/lifecycle-ledger-guard.mjsOK: every BILI_* env var read from src/ is registered in LIFECYCLE.md(171 read / 174 ledger / 16 §3 exempt)upstream/master -- LIFECYCLE.mdnode tools/gen-config-docs.mjs generate+git diff --exit-codenode tools/gen-config-docs.mjs check-coveragecoverage ok: 193 env names + 59 top-level keysnode scripts/config-surface-guard.mjsconfig-surface coverage OKnode scripts/check-unused-exports.mjsnpx tsc --noEmitNo existing open PR fixes this. The only other open PR touching
LIFECYCLE.mdis #5309 (theBILI_DSH_MAX_TESTED_VERSIONrow) — different section, different line, no conflict.Same shape as two prior docs-only incidents:
6932ab48c(#2222 →BILI_CODEX_STATE_MODE) andafd6287de(#4308 follow-up).Closes #5313.