Float the suites declaration's pragma, as every other abstract here does - #2842
Float the suites declaration's pragma, as every other abstract here does#2842thedavidmeister wants to merge 1 commit into
Conversation
`src/abstract/RaindexDeploySuites.sol` was the only abstract in this repo pinned with `=`; the other five float `^0.8.19`, and all four of the org's conforming deploy repos float `^0.8.25` on the same file. It is published: `.soldeerignore` drops `script/` and `test/` but ships `src/`, so a consumer that inherits this declaration inherits the pin with it. No bytecode moves. `foundry.toml` pins `solc = "0.8.25"`, and the concretes and scripts that inherit this still pin `=0.8.25` themselves, so the compiler this is built with is unchanged either way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 21 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
src/abstract/RaindexDeploySuites.solwas the only abstract in this repo pinned with=0.8.25; the other five float^0.8.19, and all four of the org's conforming deploy repos float^0.8.25on the same file.It is published:
.soldeerignoredropsscript/andtest/but shipssrc/, so a consumer that inherits this declaration inherits the pin with it — an exact pin on a shipped abstract forces every downstream repo onto 0.8.25 exactly.The org convention (documented in the standard derived from rain.deploy and its four conforming consumers): concretes, scripts and tests pin
=0.8.25; libraries, abstracts and generated files float^0.8.25so downstream consumers on another 0.8.x still compile.Written as part of the deploy-standard conformance work on #2841; it missed that PR's merge by a few minutes, hence this follow-up. No other conformance work is outstanding from that audit — the rest landed in
93377dee1.QA
solc 0.8.25before and after, andforge fmt --checkandrainix-sol/staticpass on the change.remappings.txt,test/abstract/layout, the 36 files importingrain-deploy-0.1.2/…via the foundry.toml alias, and the missing<Thing>DeploySuitesTest.