Skip to content

chore: bump rain-factory 0.1.1 → 0.1.5 (publishes rain-vats 0.1.7); migrate to next-version publish convention - #327

Merged
thedavidmeister merged 3 commits into
mainfrom
stox/rain-factory-0.1.5-bump
Jul 12, 2026
Merged

chore: bump rain-factory 0.1.1 → 0.1.5 (publishes rain-vats 0.1.7); migrate to next-version publish convention#327
thedavidmeister merged 3 commits into
mainfrom
stox/rain-factory-0.1.5-bump

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Bumps the rain-factory dependency 0.1.1 → 0.1.5 and migrates rain.vats onto the current rainix-autopublish next-version convention, so a rain-factory-0.1.5-based rain-vats 0.1.7 gets published.

What

  • rain-factory 0.1.1 → 0.1.5 in foundry.toml + the 4 imports that reference it (ReceiptVault.sol, OffchainAssetReceiptVaultAuthorizerV1.sol, OffchainAssetReceiptVaultPaymentMintAuthorizerV1.sol, Receipt.sol). Every one imports only {ICloneableV2, ICLONEABLE_V2_SUCCESS} — the cloneable-contract interface — which is byte-identical across 0.1.1..0.1.5. With bytecode_hash = "none" + cbor_metadata = false the bump is bytecode-neutral (no redeploy of any consumer).
  • [package].version 0.1.6 → 0.1.7. 0.1.6 was already the latest published revision, but package-release.yaml uses rainix-autopublish.yaml@main, whose next-version lifecycle requires [package].version to be the NEXT, unpublished version (the soldeer-gate enforces in-dev > published). rain.vats had drifted onto the old "version == latest-published" state; this migrates it back onto the convention so the rain-factory content change publishes as 0.1.7.
  • soldeer.lock + remappings.txt regenerated for the new pin.

Why

rain.vats only ever consumed rain-factory for the stable ICloneableV2 interface — it does not clone anything. Meanwhile st0x.deploy needs rain-factory 0.1.5's CloneFactory.cloneDeterministic for a deterministic V4-authoriser clone, but the tree was pinned to 0.1.1 through rain.vats, forcing a two-version conflict. Moving rain.vats to 0.1.5 collapses the tree to a single rain-factory version so st0x can consume it cleanly.

Downstream

Once 0.1.7 publishes, st0x.deploy bumps rain-vats 0.1.6 → 0.1.7 (single rain-factory 0.1.5), unblocking S01-Issuer/st0x.deploy#250.

Summary by CodeRabbit

  • Chores
    • Updated the project release version to 0.1.7.
    • Updated the Rain Factory dependency to version 0.1.5.
    • Refreshed dependency references across receipt and authorization components.
    • No user-facing functionality or contract behavior changed.

…onvention

rain-factory 0.1.1 -> 0.1.5 across foundry.toml + the 4 ICloneableV2 imports
(ReceiptVault, both authorizers, Receipt). ICloneableV2/ICLONEABLE_V2_SUCCESS
are byte-identical across 0.1.1..0.1.5 and metadata is stripped (bytecode_hash =
none), so the bump is bytecode-neutral.

[package].version 0.1.6 -> 0.1.7: 0.1.6 was already the latest published, but the
rainix-autopublish next-version lifecycle requires [package].version to be the
NEXT, unpublished version (its soldeer-gate enforces in-dev > published). This
migrates rain.vats onto that convention so the rain-factory content change
publishes as 0.1.7.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jul 12, 2026
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 394d769d-b0ce-4949-aa8f-a36eb64a6112

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce624c and d2382c3.

📒 Files selected for processing (21)
  • test/abstract/ReceiptFactoryTest.sol
  • test/concrete/ConcreteReceiptVault.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.authorize.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.construct.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.ierc165.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.authorize.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.construct.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.deposit.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.ierc165.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.recipientNotOwner.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.sendPaymentToOwner.t.sol
  • test/src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.verify.t.sol
  • test/src/concrete/receipt/ERC20PriceOracleReceipt.metadata.t.sol
  • test/src/concrete/receipt/Receipt.metadata.t.sol
  • test/src/concrete/receipt/Receipt.msgSenderSpoof.t.sol
  • test/src/concrete/receipt/Receipt.operatorIdentity.t.sol
  • test/src/concrete/receipt/Receipt.operatorLeak.t.sol
  • test/src/concrete/receipt/Receipt.receiptInformation.t.sol
  • test/src/concrete/receipt/Receipt.spoofEscalations.t.sol
  • test/src/concrete/receipt/Receipt.storageLayout.t.sol
  • test/src/concrete/receipt/Receipt.t.sol

Walkthrough

The package version increases to 0.1.7, and the rain-factory dependency, remapping, and Solidity imports are updated from 0.1.1 to 0.1.5.

Changes

Rain Factory dependency migration

Layer / File(s) Summary
Package and import migration
foundry.toml, remappings.txt, src/abstract/ReceiptVault.sol, src/concrete/authorize/*, src/concrete/receipt/Receipt.sol
The package version is bumped to 0.1.7, rain-factory is updated to 0.1.5, its remapping is added, and affected imports reference the new version.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the dependency bump and version publish change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stox/rain-factory-0.1.5-bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@remappings.txt`:
- Line 6: Complete the rain-factory migration by removing the obsolete
rain-factory-0.1.1 remapping and updating imports in ConcreteReceiptVault,
ReceiptFactoryTest, and the concrete authorize tests to use rain-factory-0.1.5
consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d684a126-a75a-4da8-8667-0953e2ca9842

📥 Commits

Reviewing files that changed from the base of the PR and between 8f68b12 and 1ce624c.

⛔ Files ignored due to path filters (1)
  • soldeer.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • foundry.toml
  • remappings.txt
  • src/abstract/ReceiptVault.sol
  • src/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.sol
  • src/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.sol
  • src/concrete/receipt/Receipt.sol

Comment thread remappings.txt
thedavidmeister and others added 2 commits July 12, 2026 16:24
0.1.5 CloneFactory is deterministic-only (ICloneableFactoryV3, no clone()).
Migrate the test suite off the removed non-deterministic clone():

- ReceiptFactoryTest: iFactory typed ICloneableFactoryV3; add a monotonic-salt
  cloneReceipt() helper so repeated shared-factory clones of one implementation
  never collide on their CREATE2 address.
- Shared-factory sites: iFactory.clone(impl, data) -> cloneReceipt(impl, data).
- Local single-use-factory sites: factory.clone(impl, data) ->
  factory.cloneDeterministic(impl, data, bytes32(0)) (a fresh factory per clone
  is a distinct CREATE2 deployer, so bytes32(0) cannot collide).
- Repoint remaining test rain-factory imports to 0.1.5.

Test-only; src is unchanged and stays bytecode-neutral. 344 tests pass locally.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister

Copy link
Copy Markdown
Collaborator Author

Reviewed d2382c3: rain-factory 0.1.1→0.1.5 bump + next-version publish-convention migration (0.1.6→0.1.7). src bytecode-neutral (ICloneableV2 identical, metadata stripped); test suite migrated off the removed non-deterministic clone() to cloneDeterministic with collision-safe salts (monotonic helper for the shared factory, bytes32(0) for fresh single-use local factories). All CI green — static, test (full suite incl. fork), legal, CodeRabbit. Merging to publish rain-vats 0.1.7 and unblock st0x.deploy#250.

@thedavidmeister
thedavidmeister merged commit f245a80 into main Jul 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant