chore: bump rain-factory 0.1.1 → 0.1.5 (publishes rain-vats 0.1.7); migrate to next-version publish convention - #327
Conversation
…onvention rain-factory 0.1.1 -> 0.1.5 across foundry.toml + the 4 ICloneableV2 imports (ReceiptVault, both authorizers, Receipt). ICloneableV2/ICLONEABLE_V2_SUCCESS are byte-identical across 0.1.1..0.1.5 and metadata is stripped (bytecode_hash = none), so the bump is bytecode-neutral. [package].version 0.1.6 -> 0.1.7: 0.1.6 was already the latest published, but the rainix-autopublish next-version lifecycle requires [package].version to be the NEXT, unpublished version (its soldeer-gate enforces in-dev > published). This migrates rain.vats onto that convention so the rain-factory content change publishes as 0.1.7. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (21)
WalkthroughThe package version increases to 0.1.7, and the rain-factory dependency, remapping, and Solidity imports are updated from 0.1.1 to 0.1.5. ChangesRain Factory dependency migration
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@remappings.txt`:
- Line 6: Complete the rain-factory migration by removing the obsolete
rain-factory-0.1.1 remapping and updating imports in ConcreteReceiptVault,
ReceiptFactoryTest, and the concrete authorize tests to use rain-factory-0.1.5
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d684a126-a75a-4da8-8667-0953e2ca9842
⛔ Files ignored due to path filters (1)
soldeer.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
foundry.tomlremappings.txtsrc/abstract/ReceiptVault.solsrc/concrete/authorize/OffchainAssetReceiptVaultAuthorizerV1.solsrc/concrete/authorize/OffchainAssetReceiptVaultPaymentMintAuthorizerV1.solsrc/concrete/receipt/Receipt.sol
0.1.5 CloneFactory is deterministic-only (ICloneableFactoryV3, no clone()). Migrate the test suite off the removed non-deterministic clone(): - ReceiptFactoryTest: iFactory typed ICloneableFactoryV3; add a monotonic-salt cloneReceipt() helper so repeated shared-factory clones of one implementation never collide on their CREATE2 address. - Shared-factory sites: iFactory.clone(impl, data) -> cloneReceipt(impl, data). - Local single-use-factory sites: factory.clone(impl, data) -> factory.cloneDeterministic(impl, data, bytes32(0)) (a fresh factory per clone is a distinct CREATE2 deployer, so bytes32(0) cannot collide). - Repoint remaining test rain-factory imports to 0.1.5. Test-only; src is unchanged and stays bytecode-neutral. 344 tests pass locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed d2382c3: rain-factory 0.1.1→0.1.5 bump + next-version publish-convention migration (0.1.6→0.1.7). src bytecode-neutral (ICloneableV2 identical, metadata stripped); test suite migrated off the removed non-deterministic clone() to cloneDeterministic with collision-safe salts (monotonic helper for the shared factory, bytes32(0) for fresh single-use local factories). All CI green — static, test (full suite incl. fork), legal, CodeRabbit. Merging to publish rain-vats 0.1.7 and unblock st0x.deploy#250. |
Bumps the
rain-factorydependency 0.1.1 → 0.1.5 and migratesrain.vatsonto the current rainix-autopublish next-version convention, so a rain-factory-0.1.5-basedrain-vats 0.1.7gets published.What
rain-factory0.1.1 → 0.1.5 infoundry.toml+ the 4 imports that reference it (ReceiptVault.sol,OffchainAssetReceiptVaultAuthorizerV1.sol,OffchainAssetReceiptVaultPaymentMintAuthorizerV1.sol,Receipt.sol). Every one imports only{ICloneableV2, ICLONEABLE_V2_SUCCESS}— the cloneable-contract interface — which is byte-identical across 0.1.1..0.1.5. Withbytecode_hash = "none"+cbor_metadata = falsethe bump is bytecode-neutral (no redeploy of any consumer).[package].version0.1.6 → 0.1.7. 0.1.6 was already the latest published revision, butpackage-release.yamlusesrainix-autopublish.yaml@main, whose next-version lifecycle requires[package].versionto be the NEXT, unpublished version (the soldeer-gate enforces in-dev > published). rain.vats had drifted onto the old "version == latest-published" state; this migrates it back onto the convention so the rain-factory content change publishes as 0.1.7.soldeer.lock+remappings.txtregenerated for the new pin.Why
rain.vatsonly ever consumed rain-factory for the stableICloneableV2interface — it does not clone anything. Meanwhilest0x.deployneeds rain-factory 0.1.5'sCloneFactory.cloneDeterministicfor a deterministic V4-authoriser clone, but the tree was pinned to 0.1.1 through rain.vats, forcing a two-version conflict. Moving rain.vats to 0.1.5 collapses the tree to a single rain-factory version so st0x can consume it cleanly.Downstream
Once 0.1.7 publishes, st0x.deploy bumps
rain-vats0.1.6 → 0.1.7 (single rain-factory 0.1.5), unblocking S01-Issuer/st0x.deploy#250.Summary by CodeRabbit