Repository navigation
tabs: Avoid matching :focus-visible when a trigger is clicked - #4263
Open
fushanbobfan wants to merge 1 commit into
Open
fushanbobfan wants to merge 1 commit into
fushanbobfan wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2be6547 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4262.
Since #4060,
Tabs.Triggercallsfocus()on itself inonMouseDown. At that point the browser has not registered the pointer interaction yet, so Chromium treats the script focus as keyboard focus and the clicked trigger matches:focus-visible. A mouse click then shows the focus ring whenever the previous interaction was the keyboard or nothing had been clicked yet.This change passes
{ focusVisible: false }to thatfocus()call. The call only runs for a left mouse button press, so focus from Tab and the arrow keys still matches:focus-visible.Slideralready callsfocuswith this option and declares it onFocusOptions(TypeScript 5.9's DOM lib does not have it yet);Tabsgets the same declaration. Browsers without the option ignore it and keep the current behavior.Tests
tabs: a mousedown on a trigger focuses it withfocusVisible: false. Fails onmain, passes with this change.pnpm test(48 files, 1200 passed, 2 skipped),pnpm lint,pnpm types:checkandpnpm format:checkpass.components-tabs--styled, Playwright with Chromium 149, real mouse and key events), after a fresh load and after an arrow key press, clicking a trigger matched:focus-visibleonmainand does not match with this change. An arrow key press still matches it.