Repository navigation
fix(use-size): map logical observer dimensions to physical size - #4260
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 5258d9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ResizeObserverreportsinlineSizeandblockSizeon logical axes.useSizecurrently treats them as physical width and height, which swaps dimensions in vertical and sideways writing modes.Read the element's writing mode when the observer entry arrives and keep it paired with that entry until the scheduled frame runs. Swap the logical axes for vertical and sideways modes. Keep the offset-dimension fallback unchanged, without a computed-style read. Add regression tests and a patch changeset.
Validation: four regressions fail against the original implementation, with 13 controls passing. The affected six suites pass 178 tests with the fix. Package types, lint, ESM/CJS builds, declarations and changed-file formatting pass. In a browser reproduction using the actual Checkbox consumer, a 240x80 Checkbox's hidden input changes from 80x240 before to 240x80 after.
The full monorepo run is not green: collection/import failures and one missing-workspace RSC import remain. Storybook/E2E and full monorepo build/types/lint were not run. This adds a computed-style read for border-box notifications; it is not a performance-equivalence claim. The change does not add iframe-realm or multi-fragment handling.