fix(models): remember per-model memory-fit override#339
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
quiet-node
force-pushed
the
feat/memory-fit-override
branch
from
July 18, 2026 21:59
b12f0aa to
b9cf802
Compare
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "may not fit in memory" warning fires every time a model that sits just over the safe limit is loaded, even after the user has already decided to load it. This adds an "Always allow this model" choice that remembers that decision per model, plus a Settings section to undo it. Loads that are dangerously over the limit are never remembered and always warn.
Key changes
behavior.dismissed_memory_fit_models, keyed by the model's weights SHA-256. The loader validates each entry as a real digest, dedupes, and caps the list at 64 with FIFO eviction, so a hand-edited config cannot inject garbage or grow it without bound.can_rememberflag with the fit figures, so the frontend never carries a copy of the freeze threshold.remember_model_memory_fitandforget_model_memory_fitcommands, which persist through the same lock, atomic-write, and broadcast path as every other config mutation.Testing
bun run test:all:coverageandbun run validate-buildboth pass clean, with the 100% coverage gate holding.Note
The in-chat error card still forces on a single click in both bands, unchanged from before this PR. That surface only appears in response to a turn the user just sent, so it is not the stray-click risk the ambient strip is.