qteesupplicant.service: make it conditional to /dev/tee0#52
qteesupplicant.service: make it conditional to /dev/tee0#52Ricardo Salveti (ricardosalveti) wants to merge 1 commit into
Conversation
Remove bindsto and after dev-tee0.device and replace with a conditional in order for systemd to not force a wait timeout on devices without the tee device node. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Ricardo Salveti (ricardosalveti)
force-pushed
the
qtee
branch
from
bf54ce9 to
c626d14
Compare
Ricardo Salveti (ricardosalveti)
changed the title
| Description=QTEE Supplicant Service | ||
| BindsTo=dev-tee0.device | ||
| After=dev-tee0.device sfsconfig.service | ||
| ConditionPathExists=/dev/tee0 |
There was a problem hiding this comment.
Does this mean that the After= dependency is not needed at all? Since QCOMTEE is an in-built module, a successful probe of it will always happen before this systemd unit starts? So qteesupplicant is guaranteed to run in scenarios where QCOMTEE probe is success and silently skipped when fails?
There was a problem hiding this comment.
We might be able to keep the After line, I will check, the main issue is really with BindsTo as that will force a dependency and will cause this service to be stuck (will fail after it timeouts) on devices without /dev/tee0.
There was a problem hiding this comment.
Yes understood. Then let's keep the After= if it's not causing any issues when /dev/tee0 is not available. When tee0 is available it's good to enforce that qteesupplicant start only happens after tee0 appears, otherwise qtee-supplicant start should be skipped.
2 participants
Remove bindsto and after dev-tee0.device and replace with a conditional in order for systemd to not force a wait timeout on devices without the tee device node.