Skip to content

FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA node#1377

Open
rpavanqcom wants to merge 2 commits into
qualcomm-linux:tech/all/dt/qcs6490from
rpavanqcom:ipa_fw
Open

FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA node#1377
rpavanqcom wants to merge 2 commits into
qualcomm-linux:tech/all/dt/qcs6490from
rpavanqcom:ipa_fw

Conversation

@rpavanqcom

Copy link
Copy Markdown

Enable IPA and ensure ipa apps loads the gsi firmware because modem doesn't support IPA FW loading.

Link: https://lore.kernel.org/lkml/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/T/#u

Enable IPA and ensure ipa apps loads the gsi firmware because
modem doesn't support IPA FW loading.

Link: https://lore.kernel.org/lkml/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/T/#u
Signed-off-by: Pavan Kumar M <rpavan@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested a review from a team June 18, 2026 08:39
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1377

PR: #1377
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27747413296

# Error File:Line PR-introduced? Root Cause
1 Merge conflict arch/arm64/boot/dts/qcom/qcm6490-idp.dts N/A PR branch is out of sync with integration baseline; the file has been modified in the integration branch since PR was created

Verdict

This is not a compilation failure but a merge conflict. The PR needs to be rebased on the current integration branch baseline (8dba9258929fce68a7b0d148c2a461ba2159f930) to resolve conflicts in qcm6490-idp.dts.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1377

PR: #1377
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27747413296

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/qcm6490-idp.dts Yes The PR adds an &ipa node to qcm6490-idp.dts, but the integration branch has conflicting changes in the same region of the file. The conflict occurred when merging PR #1377 into the integration branch that already includes topic/tech/net/rmnet.

Verdict

This is a merge conflict, not a compilation error. The build failed during the git merge step before any compilation occurred. The PR needs to be rebased on the current integration branch to resolve the conflict.

📎 Detailed analysis: Full report

@rpavanqcom rpavanqcom changed the base branch from tech/net/rmnet to tech/all/dt/qcs6490 June 18, 2026 09:28
Signed-off-by: rpavanqcom <rpavan@qti.qualcomm.com>
@qcomlnxci qcomlnxci requested review from a team, Komal-Bajaj, jingyiwang42 and mukeshojha-linux and removed request for a team June 18, 2026 09:32
@qlijarvis

Copy link
Copy Markdown

PR #1377 — validate-patch

PR: #1377

Verdict Issues Detailed Report
10 Full report

Final Summary

  1. Lore link present: Yes — link provided in commit message footer
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable
  3. Upstream patch status: Unknown — cannot fetch from lore; FROMLIST prefix suggests patch is under review but not yet merged
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Required Actions:

  1. Fix commit message formatting: separate subject from body with blank line
  2. Ensure subject line is ≤75 characters
  3. Fix grammar: "ipa apps loads" → "IPA apps load"
  4. Verify lore link is valid and points to the correct upstream submission
  5. Confirm patch content matches upstream version exactly (when network available)
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1377 - arm64: dts: qcom: qcm6490-idp: add and enable IPA node
Upstream commit: https://lore.kernel.org/lkml/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/T/#u (unable to verify - network restricted)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore link inaccessible; subject line malformed (missing newline)
Body preserves rationale Commit message body merged into subject line; no proper paragraph structure
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Author: Pavan Kumar M rpavan@qti.qualcomm.com
Backport note (if applicable) N/A FROMLIST prefix indicates pending upstream submission

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcm6490-idp.dts:515 IPA node configuration looks syntactically correct

Issues

Critical: Commit Message Formatting

  • The subject line and body are improperly merged into a single line:
    Subject: [PATCH] FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA
     node Enable IPA and ensure ipa apps loads the gsi firmware because modem
     doesn't support IPA FW loading.
    
  • Expected format:
    Subject: [PATCH] FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA node
    
    Enable IPA and ensure ipa apps loads the gsi firmware because modem
    doesn't support IPA FW loading.
    
  • The subject line must be a single, concise line (≤75 chars recommended)
  • The body must be separated from the subject by a blank line
  • Current subject is 138+ characters when unwrapped

Minor: Grammar

  • "ipa apps loads" should be "IPA apps load" (subject-verb agreement)
  • Consider: "Enable IPA and configure it to load GSI firmware from the application processor, as the modem does not support IPA firmware loading."

Lore Link Verification

  • Cannot verify patch content matches upstream (network access restricted)
  • Link format appears valid but message ID may not exist (dated 2025-03-04, but PR date is 2026-06-18)
  • The lore link uses /T/#u fragment which is unusual; typically raw patches use no fragment or /raw

Verdict

Reject - Commit message formatting is broken and must be fixed before merge. The subject and body are improperly concatenated, violating kernel commit message standards.

Final Summary

  1. Lore link present: Yes — link provided in commit message footer
  2. Lore link matches PR commits: Cannot verify — network access restricted; lore.kernel.org unreachable
  3. Upstream patch status: Unknown — cannot fetch from lore; FROMLIST prefix suggests patch is under review but not yet merged
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Required Actions:

  1. Fix commit message formatting: separate subject from body with blank line
  2. Ensure subject line is ≤75 characters
  3. Fix grammar: "ipa apps loads" → "IPA apps load"
  4. Verify lore link is valid and points to the correct upstream submission
  5. Confirm patch content matches upstream version exactly (when network available)

@qlijarvis

Copy link
Copy Markdown

PR #1377 — checker-log-analyzer

PR: #1377
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27750261021

Checker Result Summary
Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - Author mismatch & content differs from upstream
tag-check N/A Not applicable for this PR
qcom-next-check FROMLIST prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1377 - FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA node
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27750261021

Checker Result Summary
checkpatch No style issues detected
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check DTB validation passed
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FAILED - Author mismatch & content differs from upstream
tag-check N/A Not applicable for this PR
qcom-next-check FROMLIST prefix present

❌ check-patch-compliance

Root cause: The commit author differs from the original upstream patch author, and the patch content does not match the linked lore.kernel.org patch.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: qcm6490-idp: add and enable IPA node Enable IPA and ensure ipa apps loads the gsi firmware because modem doesn't support IPA FW loading.

Change is different from the one mentioned in Link

Author mismatch:
  Original author: Kaustubh Pandey <quic_kapandey@quicinc.com>
  Commit author : Pavan Kumar M <rpavan@qti.qualcomm.com>

Analysis:

The check-patch-compliance checker validates that FROMLIST/UPSTREAM patches match their upstream source. This PR fails on two counts:

  1. Author Mismatch: The original patch on lore.kernel.org was authored by Kaustubh Pandey <quic_kapandey@quicinc.com>, but the commit in this PR is authored by Pavan Kumar M <rpavan@qti.qualcomm.com>. When backporting FROMLIST patches, the original author must be preserved.

  2. Content Difference: The checker detected that the patch content differs from what was posted to the mailing list at the linked URL: https://lore.kernel.org/lkml/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/T/#u

Fix:

To resolve this failure, you must:

  1. Preserve the original author: Use git commit --amend --author="Kaustubh Pandey <quic_kapandey@quicinc.com>" to set the correct author, or cherry-pick the original patch with git cherry-pick -x to maintain authorship.

  2. Ensure patch content matches upstream: Fetch the exact patch from lore.kernel.org using b4:

    b4 am https://lore.kernel.org/lkml/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/
    git am ./v1_*.mbx

    This ensures the patch content, commit message, and authorship all match the upstream submission.

  3. Add your sign-off: After applying the original patch, add your Signed-off-by trailer to indicate you've reviewed and tested it:

    git commit --amend -s

Reproduce locally:

cd /path/to/kernel-topics
git fetch origin pull/1377/head:pr-1377
git checkout pr-1377

# Clone kernel-checkers
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run the compliance check
bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base 8dba9258929fce68a7b0d148c2a461ba2159f930 \
  --head HEAD

Verdict

1 blocker to fix: The check-patch-compliance failure must be resolved before this PR can be merged. The patch must preserve the original author (Kaustubh Pandey) and match the content posted to lore.kernel.org. All other checkers passed or were correctly skipped.

@shashim-quic

Copy link
Copy Markdown
Collaborator

can you rebase on latest baseline

@rpavanqcom

Copy link
Copy Markdown
Author

can you rebase on latest baseline

I have already rebased this & I don't see any conflicts on tip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants