Repository navigation
Conversation
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
merydian
force-pushed
the
fix-wrong-time-diplay-in-wmst
branch
from
October 26, 2026 14:30
5cdc95d to
701b671
Compare
merydian
force-pushed
the
fix-wrong-time-diplay-in-wmst
branch
from
October 27, 2026 20:29
9593eec to
8173b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The member QDateTimeEdits of QgsTemporalControllerWidget currently do not have a time specification set.
From the QDateTimeEdit docs:
When then reading from a QDateTimeEdit again after setting a CET, there will currently be a time shift. Thus the new test before fails:
(see: https://github.com/qgis/QGIS/actions/runs/40578527565/job/122509265577)
It's a 1h shift, since CET is UTC+1. The year here switches, since its around 1st of January.
This PR sets the time specification of the member QDateTimeEdits of QgsTemporalControllerWidget to excpect local time. This prevents the time shift when rereading the time from e.g. mStartDateTime in QgsTemporalControllerWidget.
Closes #67917
No LLM, AI or agent assisted code contributions are allowed in the QGIS repository. If we subsequently discover that you have used an AI, LLM, or any agent-based workflow for your contribution, you will be subject to code reversion and contributor rights sanctioning. See QEP 408 for details.