Pin ruff so the lint gate is reproducible - #7
Merged
Merged
Conversation
The lint job installed ruff unpinned, so it ran whatever version was newest at the time. ruff 0.16 enables rules that did not exist at 0.6 and reports 126 findings on an untouched tree, which turned the gate red on main with no change to the code — and made every open PR look broken. Pins the range the framework repo already uses for its dev dependency. Adopting a newer ruff is worth doing, but as its own change, alongside the findings it reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintjob runspip install ruffwith no constraint, so it installs whatever version is newest when it runs. ruff 0.16 enables rules that did not exist at 0.6 and reports 126 findings on an untouched tree, so the gate went red onmainwithout any code change — and every open PR inherited the failure, making unrelated dependency bumps look broken.This pins the same range the framework repo already uses for its dev dependency (
ruff>=0.6,<0.7). Verified: that version reportsAll checks passedon the current tree, while 0.16.1 reports 126.Adopting a newer ruff is worth doing — it has genuinely useful rules — but as a deliberate change that also fixes what it reports, not as a silent dependency drift that breaks the build for everyone.