Improving Paragraph.text performance by 500%~#1118
Open
yoniy-talon wants to merge 1 commit intopython-openxml:masterfrom
Open
Improving Paragraph.text performance by 500%~#1118yoniy-talon wants to merge 1 commit intopython-openxml:masterfrom
yoniy-talon wants to merge 1 commit intopython-openxml:masterfrom
Conversation
cenedella
approved these changes
Mar 14, 2023
cenedella
left a comment
cenedella
left a comment
There was a problem hiding this comment.
Would be great to have these changes accepted into the library.
|
@scanny Could we please get a timeline, when this would be able to be merged or what needs to be adjusted? |
|
You don't even need to create a list, just pass the generator itself to join. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my tests with large docx files with @DrorRoth, we managed to increase Paragraph.text performance by 500%~ using this simple fix.