Skip to content

Allowing for pinocchio backend#1055

Merged
pariterre merged 12 commits into
pyomeca:masterfrom
pariterre:codex/pinocchio-model-backend
Jun 3, 2026
Merged

Allowing for pinocchio backend#1055
pariterre merged 12 commits into
pyomeca:masterfrom
pariterre:codex/pinocchio-model-backend

Conversation

@pariterre

@pariterre pariterre commented Jun 2, 2026

Copy link
Copy Markdown
Member

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@pariterre

Copy link
Copy Markdown
Member Author

This PR replaces the #1051 (rebased and upgraded)

@pariterre pariterre mentioned this pull request Jun 2, 2026
11 tasks
@pariterre pariterre force-pushed the codex/pinocchio-model-backend branch from b2b957d to 69babe3 Compare June 3, 2026 19:03
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.66213% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.26%. Comparing base (a01ed91) to head (691129a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
bioptim/models/pinocchio/pinocchio_model.py 69.74% 95 Missing ⚠️
...ptim/examples/getting_started/example_pinocchio.py 77.41% 7 Missing ⚠️
bioptim/models/utils.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   77.21%   77.26%   +0.04%     
==========================================
  Files         192      196       +4     
  Lines       21148    21508     +360     
==========================================
+ Hits        16330    16618     +288     
- Misses       4818     4890      +72     
Flag Coverage Δ
unittests 77.26% <71.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pariterre pariterre merged commit 1abff89 into pyomeca:master Jun 3, 2026
22 of 23 checks passed
@pariterre pariterre deleted the codex/pinocchio-model-backend branch June 3, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants