macos_online_fix#1047
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
+ Coverage 77.00% 77.21% +0.21%
==========================================
Files 192 192
Lines 21127 21148 +21
==========================================
+ Hits 16269 16330 +61
+ Misses 4858 4818 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pariterre
left a comment
There was a problem hiding this comment.
@pariterre reviewed 10 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on mickaelbegon).
bioptim/examples/getting_started/basic_ocp.py line 192 at r2 (raw file):
print("Animation skipped because bioviz is not installed.") else: raise
I don't understand the benefit of this check as it already fails like so when bioviz is not installed.. I think commenting is better...
(Changes are already done)
pariterre
left a comment
There was a problem hiding this comment.
@pariterre reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on mickaelbegon).
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*")?Changes to Core Features:
This PR enables
online_optimon macOS by switchingOnlineOptim.DEFAULTtoMULTIPROCESS_SERVERinstead of disabling online plotting entirely.It also fixes the supporting issues that showed up during macOS validation:
MULTIPROCESSexplicitly unsupported on macOSbasic_ocpanimation cleanly whenbiovizis not installedI split the change into two commits:
c9811420Enable macOS online plotting via multiprocess server2b17fb3eHarden macOS plotting example fallbacksThis change is