Rename Sobol sensitivity method#938
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #938 +/- ##
===========================================
+ Coverage 89.41% 92.11% +2.69%
===========================================
Files 63 74 +11
Lines 4857 5784 +927
===========================================
+ Hits 4343 5328 +985
+ Misses 514 456 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Alternatively, we can deprecate the function and move SALib into the optional dependencies, as SALib is only used directly in the examples. What do you think @Dibyendu-IITKGP ? |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Neat, thanks, I see that this was removed completely! Let's also update this section as well: https://pybop-docs.readthedocs.io/en/latest/installation.html#optional-dependencies
…-team/PyBOP into rename-sobol-sensitivities
|
Thanks @agriyakhetarpal, I've added the more recent optional dependencies to the docs, good spot! |
Description
Add a check for finite bounds and specify the method by renaming
sensitivity_analysistoget_sobol_sensitivities.Fixes #657
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)nox -s testsnox -s doctest