Fixed for iOS 6, all-day events, reminder param, success/failure callbacks#105
Open
trevoriancox wants to merge 2 commits into
Open
Fixed for iOS 6, all-day events, reminder param, success/failure callbacks#105trevoriancox wants to merge 2 commits into
trevoriancox wants to merge 2 commits into
Conversation
Added support for all day events. Reminder alarm offset may be specified as optional parameter (now defaults to none instead of 2h). Replaced hard-coded alert on success with optional success and failure callbacks. On failure, get user-friendly error message from system.
Merge main branch's addition of a new calendarName parameter with my code that added reminder, success and fail parameters. Compatible with main branch. Conflicts merged: iOS/CalendarPlugin/README iOS/CalendarPlugin/calendar.js iOS/CalendarPlugin/calendarPlugin.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed for iOS 6 (prompt for calendar permission).
Added support for all day events.
Reminder alarm offset may be specified as optional parameter (now defaults to none instead of 2h).
Replaced hard-coded alert on success with optional success and failure callbacks.
On failure, get user-friendly error message from system.