Skip to content

Maoyuan/dora rel i cache fix - #173

Open
MaoyuanCai wants to merge 10 commits into
dorafrom
maoyuan/dora-relICache_fix
Open

MaoyuanCai wants to merge 10 commits into
dorafrom
maoyuan/dora-relICache_fix

Conversation

@MaoyuanCai

Copy link
Copy Markdown
Contributor

The current CI failures are caused by the missing TCDM interconnect changes in the dora branch. This PR should be merged only after #164 has been merged and the CI checks have passed.

@Camma2001 Camma2001 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase required

@Camma2001

Copy link
Copy Markdown
Collaborator

Review also hw/system/spatz_cluster/cfg/spatz_quadrilatero.dora.dram.hjson, the iCache Line Width and Count are defined there.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 590: "File must end with a newline." needs to be addressed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 626: "File must end with a newline." needs to be addressed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 4522: "File must end with a newline." needs to be addressed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 157: "File must end with a newline." needs to be addressed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 278: "File must end with a newline." needs to be addressed

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint comment at line 1884: "File must end with a newline." needs to be addressed

Comment thread Bender.yml
idma: { git: "https://github.com/pulp-platform/iDMA.git", version: 0.6.4 }
register_interface: { git: "https://github.com/pulp-platform/register_interface.git", version: 0.4.7 }
cluster_icache: { git: "https://github.com/pulp-platform/cluster_icache.git", version: 0.2.0 }
cluster_icache: { git: "https://github.com/pulp-platform/cluster_icache.git", rev: maoyuan/relICache}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a compilation error in cluster_icache:

The class 'icache_request' is defined more than once (line 7 and 8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants