build: Replace morty with the bender slang pickle#110
Open
DanielKellerM wants to merge 1 commit into
Open
Conversation
bender >= 0.32.0 pickles via its vendored slang frontend: no sources.json indirection, no cf_math_pkg concat hack, and roughly 25x faster. Morty's HTML doc and DOT graph outputs are retired together with their Sphinx references, so morty and graphviz drop out of the prerequisites entirely.
There was a problem hiding this comment.
Pull request overview
This PR migrates iDMA’s “pickling” (single-file SystemVerilog extraction) flow from Morty to Bender’s pickle (slang frontend), simplifying the build pipeline and removing the Morty/Graphviz-based documentation artifacts and CI setup while keeping the existing target/morty output path for downstream compatibility.
Changes:
- Switch
idma.mkpickling frommorty+sources.json+cf_math_pkgconcatenation hack tobender pickle. - Remove Morty-generated HTML/DOT graph references from Sphinx sources and drop Graphviz/Morty installs from GitHub Actions workflows.
- Bump required/installed Bender version to
0.32.0and remove Morty from prerequisites/ignore lists.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates prerequisites to require newer Bender and drops Morty requirement. |
| idma.mk | Replaces Morty-based pickling and graph/doc generation with bender pickle; updates clean targets accordingly. |
| doc/src/midend.rst | Removes Morty doc/graph references; keeps brief midend description. |
| doc/src/index.rst | Removes Morty-generated documentation links and embedded hierarchy images. |
| doc/src/frontends/descriptor_fe.rst | Removes Morty doc/graph references for the descriptor frontend section. |
| .gitignore | Stops ignoring a top-level morty binary since CI no longer installs it. |
| .github/workflows/docs.yml | Removes Graphviz and Morty install steps; installs Bender 0.32.0. |
| .github/workflows/deploy.yml | Removes Morty install step; installs Bender 0.32.0. |
| .github/workflows/build.yml | Removes Graphviz and Morty install steps; installs Bender 0.32.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bender pickle(bender >= 0.32.0, slang frontend) replaces morty for all pickling: nosources.jsonindirection, nocf_math_pkgconcat hack, ~25x faster.target/mortyfor downstream compatibility; rename planned as a follow-up.Merge before #111 (adjacent hunks in the same workflow files).
Follow-ups planned:
target/picklerename,bender script --toptrimmed compile scripts,--ast-json-based doc graphs,db_dirdependency caching.