Add a Pusher.PushWithTimeout method, resetting the context timeout - #2089
Open
jwreschnig-utiq wants to merge 1 commit into
Open
Add a Pusher.PushWithTimeout method, resetting the context timeout#2089jwreschnig-utiq wants to merge 1 commit into
Pusher.PushWithTimeout method, resetting the context timeout#2089jwreschnig-utiq wants to merge 1 commit into
Conversation
jwreschnig-utiq
requested review from
bwplotka,
kakkoyun and
vesari
as code owners
August 14, 2026 14:35
jwreschnig-utiq
force-pushed
the
push-timeout
branch
2 times, most recently
from
August 14, 2026 14:44
a6003d1 to
fb911d6
Compare
When a job fails due to a higher-level context being canceled (for example, a global timeout) it is easy to reuse that context to push metrics, which fails immediately and metrics pertaining to the original failure will be lost. Use this method for an additional grace period beyond the original context's deadline. Signed-off-by: Joe Wreschnig <joe.wreschnig@utiq.com>
jwreschnig-utiq
force-pushed
the
push-timeout
branch
from
August 14, 2026 14:59
fb911d6 to
9e2af8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an issue I find myself correcting often during our internal code review.
When a job fails due to a higher-level context being canceled (for example, a global timeout) it is easy to reuse that context to push metrics, which fails immediately and metrics pertaining to the original failure will be lost. Use this method for an additional grace period beyond the original context's deadline.