Keep completed WebView history updates from restarting loading - #94
Merged
Conversation
ThreatCrush Security Scan49 finding(s) MEDIUM: 31 | LOW: 18
Snippets are redacted; ThreatCrush never prints matched credential material. |
ralyodio
marked this pull request as ready for review
September 8, 2026 05:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Draft follow-up to #92/#93; not a native release approval.
Android WebView history updates can emit
onLoadStartwithloading=false, without a later load-end event. BrowserScreen used to turn the spinner on unconditionally and leave it spinning indefinitely.Use the event's loading boolean on Android only. Preserve iOS's original unconditional start indication: its native callback is emitted before the new navigation is allowed and can sample loading=false. Keep load-end handling, navigation/security policy, reload and tab persistence unchanged.
Verification
Remaining Gate
No iOS/Android native runtime was executed for this patch. Check first navigation and post-error reload on native WebView: event ordering could still omit a spinner even though the endless-spinner path is fixed. Browser/component mocks do not establish native dispatch timing.
No EAS build, store submission, production deployment or native project change was made. Keep draft until these limits are reviewed.