fix(ci): SDK publish skips cleanly when the @threatcrush scope is missing - #261
Merged
Merged
Conversation
…sing The npm-publish workflow gained a "Publish SDK" job that fails E404 "Scope not found" on every release since v0.13.10, because the @threatcrush npm org/scope was never created (the CLI ships under @profullstack). That is a not-yet-set-up state, not a release failure, and the separate CLI publish job is unaffected — but the red job made every release look broken. Skip green on scope-not-found (with a warning naming the two ways to actually enable it: create the org, or rename under @profullstack); still fail on any real error (auth, version conflict, build). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ThreatCrush Security Scan16 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 7 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every release since v0.13.10 shows a red X: the "Publish SDK to npm" job fails with
npm error 404 Scope not found - @threatcrush/sdk. The@threatcrushnpm org/scope was never created (the CLI ships as@profullstack/threatcrush), and the SDK is documented as "not on npm yet." The separate CLI publish job succeeds, so releases do reach npm — but the release looks broken.Fix
The SDK publish step now treats scope-not-found (E404) as a clean skip (with a
::warning::naming the two ways to actually enable it), while still failing on any real error — auth, version conflict, build. Workflow-only change.To actually publish the SDK later (separate decision)
@threatcrushnpm org, or@profullstackscope (touches ~30 files: every module/boilerplate imports@threatcrush/sdk).🤖 Generated with Claude Code