fix(tcfeed): finish a pair the run left half-open - #127
Merged
Merged
Conversation
GitHub returned 502s for a stretch this afternoon, and two repositories
came out of it with an issue and no pull request:
DingTalk-Real-AI/dingtalk-workspace-cli — fork failed, HTTP 502
GSF-001/ARCLUX — push failed
Their issues say "I am opening a pull request alongside this so the diff
is there to read", which is now untrue. That is a promise made to a
maintainer and then not kept, and the issue dedup added with the
issue-first flow was too coarse to let it be repaired: any issue at all,
in any state, meant never ask again.
An issue on its own says which of two things happened, and the states
mean opposite things. Reaching that check means no pull request exists in
any state, so:
closed — they answered, and the answer was no. Exactly what the issue
is for, and it must never be followed by a pull request.
open — the pair was interrupted between the two calls. Finishing it
is not a second ask; it is the first one, completed.
An open issue is now carried out of prTarget so the run reuses it instead
of opening a duplicate, and says so: "finishing <url>, which has no
request yet".
Verified both directions: ARCLUX resumes onto its existing issue, and a
repository that answered still skips.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub returned 502s for a stretch this afternoon and two repositories came out of it with an issue and no pull request:
Their issues say "I am opening a pull request alongside this so the diff is there to read", which is now untrue — a promise made to a maintainer and then not kept.
The issue dedup added with the issue-first flow was too coarse to repair it: any issue, in any state, meant never ask again.
The two states mean opposite things
Reaching that check means no pull request exists in any state, so an issue on its own says which of two things happened:
An open issue is now carried out of
prTargetso the run reuses it instead of opening a duplicate, and says so.Verified both directions
tsc --strict --noEmitclean.Resumes onto the existing issue:
And a repository that already answered still skips:
🤖 Generated with Claude Code