Validate Firefox publish channels by rissrice2105-agent · Pull Request #607 · profullstack/sh1pt

rissrice2105-agent · 2026-06-05T17:52:04Z

Fixes #606.

Changes:

validate browser-firefox channel at runtime before package planning or shipping
keep package plans and ship logging constrained to listed/unlisted AMO channels
add regression tests for invalid channel in dry-run build and ship flows

Validation:

vitest run packages/targets/browser-firefox/src/index.test.ts
tsc -p packages/targets/browser-firefox/tsconfig.json --noEmit

greptile-apps · 2026-06-05T17:55:04Z

Greptile Summary

This PR adds runtime validation of the Firefox AMO publish channel in both the build and ship paths, throwing immediately on any unsupported value before filesystem or network side-effects occur. Two regression tests cover the invalid-channel case for dry-run build and ship flows.

channel() helper centralises default ('listed') and validation logic, replacing inline config.channel ?? 'listed' expressions in packagePlan and ship.
The valid-channel set (CHANNELS) is now checked at runtime, but it is defined separately from the Config.channel union type and FirefoxPackagePlan.channel field — a future addition to one without updating the others could cause a mismatch.

Confidence Score: 4/5

Safe to merge; the validation logic is correct, tests cover the new throw paths, and no existing behaviour is broken.

The channel() function works correctly at runtime and the tests confirm it. The only concern is that the valid-channel set is expressed three times independently (CHANNELS, Config.channel, FirefoxPackagePlan.channel), leaving room for silent drift if a channel is added later.

packages/targets/browser-firefox/src/index.ts — the three separate declarations of 'listed' | 'unlisted' are worth unifying.

Important Files Changed

Filename	Overview
packages/targets/browser-firefox/src/index.ts	Adds a `channel()` helper that validates and returns the AMO channel before any side effects in both `build` and `ship`; the valid channel set is currently duplicated across `CHANNELS`, the `Config` type, and `FirefoxPackagePlan`.
packages/targets/browser-firefox/src/index.test.ts	Adds two regression tests covering invalid-channel rejection in both dry-run build and ship paths; imports `fakeShipContext` as needed.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[build / ship called] --> B[channel config]
    B --> C{config.channel set?}
    C -- No --> D[default to 'listed']
    C -- Yes --> E[use provided value]
    D --> F{value in CHANNELS?}
    E --> F
    F -- No --> G[throw Error: must be one of listed, unlisted]
    F -- Yes --> H[return selectedChannel]
    H --> I{ship path?}
    H --> J{build path?}
    I --> K[ctx.log sign+submit]
    K --> L{dryRun?}
    L -- Yes --> M[return dry-run]
    L -- No --> N[submit to AMO]
    J --> O[packagePlan created]
    O --> P{dryRun?}
    P -- Yes --> Q[write .firefox-plan.json]
    P -- No --> R[exec web-ext build]