Repository navigation
deploy-ssh 0.1.2: www and other aliases 301 to the first domain; reload nginx on config change - #1035
Merged
Merged
Conversation
…ad nginx on config change OpenInstall's nginx site listed every DOMAINS name in both server blocks and redirected port 80 to https://$host, so www.example.com served the app as a second hostname (pit.world answered 200 with an empty body there). The first name is now canonical: port 80 and a separate 443 block for the others answer 301 to https://<first>. The no-cert path is unchanged so certbot's first challenge still reaches every name. Also: write_nginx piped nginx_conf into put_root_file, so CHANGED=1 was set in a subshell and a changed config never triggered the reload. Process substitution instead. Same fixes as moshcoder/pit.world #5 and #6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan53 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 17 | LOW: 35
…and 3 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the canonical OpenInstall
install.sh. Both are already live on pit.world (moshcoder/pit.world #5, #6).DOMAINSis canonical. Port 80 and a new 443 block for every other name (e.g.www.) return 301 tohttps://<first>$request_uri, and the app block serves only the first name. Before this,https://www.pit.world/returned 200 with an empty body. The no-cert path is unchanged, so certbot's first HTTP challenge still reaches every name.nginx_conf | put_root_fileranput_root_filein a subshell, soCHANGED=1was lost and the reload never ran. It now uses process substitution.Bumps deploy-ssh to 0.1.2. cli-tools' vendored
templates/openinstall/install.shfollows.🤖 Generated with Claude Code