Add calendar links to meeting invite and update emails - #109
Merged
Merged
Conversation
The invite email now carries Google and Outlook links plus the .ics attachment, like the reminder. The update email gets the links only: it goes out through Resend's batch endpoint, which cannot attach. The "Add to calendar" row moves into lib/calendar.ts so the three emails share one markup, with an `attached` flag that drops the attachment note for bulk sends. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ThreatCrush Security Scan34 finding(s) HIGH/CRITICAL: 4 | MEDIUM: 26 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #108. The invite email (sent when a meeting is created) now has the same "Add to calendar" row with Google and Outlook links and attaches the
.ics. The update email ("Updated: …") gets the links too, without the attachment.Why no attachment on updates
sendBulkgoes through Resend's batch endpoint, which does not carry attachments (the emailer's bulk options have noattachmentsfield either). The update email links out instead, and the row's copy drops the "open the attached .ics" note for that case.How
lib/calendar.ts: newcalendarLinksHtml({ googleCalendarUrl, outlookUrl, attached })so the reminder, invite and update emails share one markup. The reminder runner now uses it (no visible change).app/actions/meetings.ts:calendarEventForbuilds oneCalendarEventper meeting (UID =<session id>@pairux.comon invites, recurrence as RRULE). Invite sends attach the base64.ics; update sends pass the event for links only.Tests
calendar.test.tsgains 2 tests for the row helper (attached vs bulk).tsc --noEmit, eslint, prettier clean on touched files; 70/70 pass across calendar, reminders, join, invite and scheduled-sessions suites.🤖 Generated with Claude Code