publish: a dispatch aimed at a tag gets the version check too - #99
Merged
Merged
Conversation
github.ref_type says whether the run is on a tag, whichever trigger put it there. Matching on the event name let a dispatch from a tag skip the check that the tag names the version it publishes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98. This commit was on the branch (
0a5bb7a) but the squash merge landed at4e90fbb, so it did not reach main.RELEASE_EVENTdecides whetherscripts/publish.mjsenforces that the tag names the version it is about to publish. Matching on the event name means aworkflow_dispatchaimed at a tag ref reportsdispatch, and skips the check — on the one path where a tag is present and the check would apply.github.ref_typesays whether the run is on a tag whichever trigger put it there, so all three ways in are covered:ref_typeRELEASE_EVENTv*release: publishedNo behaviour change on the two automatic paths.
🤖 Generated with Claude Code