Repository navigation
fix(fleet-sync): create the destination path, same path lands flat, show + copy the real error - #66
Merged
Merged
Conversation
…at, show the real error
A Fleet Sync of ~/Desktop/me/ideas from bonita to dev2 failed with code 11
("io/write error") and the error was unreadable. Four fixes:
- Fleet Sync now passes --mkpath (via buildPlan overrides; the planner drops
it with a warning on rsync older than 3.2.3), so a path that does not exist
yet on a destination is created instead of failing with code 11.
- An empty (or identical) destination now sends the source into its parent,
so the same path lands at the same path. Before, rsync's trailing-slash rule
would have produced ~/Desktop/me/ideas/ideas.
- rsync's "mkdir ... failed: No such file or directory" is reported as what it
is (a missing parent folder), and code 11 no longer claims the destination
"may be full or read-only".
- A failed destination shows an error block under its row: the cause, rsync's
own lines (kept, not overwritten by the exit summary), selectable text, and a
Copy error button. It used to be a faint truncated snippet in an otherwise
empty panel, and the app's no-select default made it uncopyable.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Fleet Sync of
~/Desktop/me/ideas(this machine) to dev2 failed with code 11 and the error box was empty and uncopyable. Reproduced from bonita's CLI:rsync: [Receiver] mkdir "/home/anthony/…/me/ideas" failed: No such file or directory, shown to the user as "the destination filesystem may be full or read-only".--mkpath(main-process override; the planner drops it with a warning on rsync < 3.2.3). Verified live bonita → dev2: the nested path is created.~/a/ideasarrives as~/a/ideas, not~/a/ideas/ideas(rsync's trailing-slash rule; seen in the live test).Tests: rsync-core errors (+2),
src/lib/fleet-sync.test.ts(5). Full suite 73 files / 938 tests.🤖 Generated with Claude Code