fix: windows compatibility#185
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d73688. Configure here.
lihbr
commented
May 12, 2026
| } | ||
| const projectRoot = new URL(".", configPath); | ||
| return projectRoot; | ||
| return appendTrailingSlash(pathToFileURL(await realpath(fileURLToPath(projectRoot)))); |
Member
Author
There was a problem hiding this comment.
This is a bit weird, but basically we need to ensure we resolve real paths on Windows, otherwise some paths yield %USERPROFILE% while others yield actualUserName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: N/A
Description
Adds Windows CI and fixes Windows incompatibilities.
Checklist
Preview
How to QA 1
Note
Medium Risk
Medium risk because it changes filesystem path resolution (via
realpath) and globbing behavior, which can affect how projects are discovered and models are located across platforms.Overview
Improves cross-platform (especially Windows) support by making model discovery globs POSIX-friendly (
tinyglobbywithcwdinstead of URL-to-path glob strings) and normalizing project/Git roots viarealpathbefore converting tofile://URLs.Expands CI to test multiple Node versions and adds a dedicated Windows test job, and hardens tests for Win32 by increasing install-related timeouts, making temp dir cleanup more resilient, and adjusting path assertions to use platform separators.
Reviewed by Cursor Bugbot for commit c501c2d. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩