initial commit for factor graph diff experiments with diff_factors#69
Draft
nosmokingsurfer wants to merge 19 commits into
Draft
initial commit for factor graph diff experiments with diff_factors#69nosmokingsurfer wants to merge 19 commits into
nosmokingsurfer wants to merge 19 commits into
Conversation
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
g-ferrer
reviewed
May 29, 2024
nosmokingsurfer
commented
May 29, 2024
nosmokingsurfer
left a comment
Collaborator
Author
There was a problem hiding this comment.
Hi, I will update file information comments, do clean up of EF methods adn etc and will remove redundant header includes where possible, but I have issues with headers in places where I do inheritance. In child class I need to include parent class header so the compiler can build object files for those classes. Linker works after all objects compiled - thus, compiler must know parent class declaration (method signature for example) to find them in corresponding parent object file.
e46dad3 to
4c00262
Compare
229b07f to
a75dc25
Compare
835a4a8 to
9ad8cbf
Compare
0140188 to
719d661
Compare
719d661 to
ffa37a4
Compare
…eigen_factor_diff class/ methods
7fbe9cd to
1894f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FGraphDiffmodule for experiments with differentiable factorsTODO list:
DiffFactorfactor1Pose2_difffactor2Pose2_diffFGraphDiffFGraphDiffSolveFGraphDiffmrob/src/FGraphDiff/examples/example_solver_2d.cpp- works with GN method/mrob/python_examples/FGraphDiff_2d.py- works with GN method