Skip to content

initial commit for factor graph diff experiments with diff_factors#69

Draft
nosmokingsurfer wants to merge 19 commits into
masterfrom
feature/fgo_diff
Draft

initial commit for factor graph diff experiments with diff_factors#69
nosmokingsurfer wants to merge 19 commits into
masterfrom
feature/fgo_diff

Conversation

@nosmokingsurfer

@nosmokingsurfer nosmokingsurfer commented May 28, 2024

Copy link
Copy Markdown
Collaborator

FGraphDiff module for experiments with differentiable factors

TODO list:

  • abstract DiffFactor
  • factor1Pose2_diff
  • factor2Pose2_diff
  • FGraphDiff
  • FGraphDiffSolve
  • derive and define diff-factor methods:
  • evaluate_dr_dz()
  • evaluate_dr_dx()
  • evaluate_d2r_dx_dz()
  • python bindings for FGraphDiff
  • example project: mrob/src/FGraphDiff/examples/example_solver_2d.cpp - works with GN method
  • example python project: /mrob/python_examples/FGraphDiff_2d.py- works with GN method
  • resolve parent include headers ugly paths "#include "../FGraph/mrob/factor.hpp" - somehow using cmake probably?
  • move whole gradient method from example into single funciton call
  • update python bindings
  • compose python training example

@nosmokingsurfer nosmokingsurfer added the enhancement New feature or request label May 28, 2024
@nosmokingsurfer nosmokingsurfer requested a review from g-ferrer May 28, 2024 21:37
@nosmokingsurfer nosmokingsurfer self-assigned this May 28, 2024
Comment thread src/FGraphDiff/CMakeLists.txt Outdated
Comment thread src/FGraphDiff/CMakeLists.txt Outdated
Comment thread src/FGraphDiff/examples/example_solver_2d.cpp Outdated
Comment thread src/FGraphDiff/factors/factor1Pose2d_diff.cpp Outdated
Comment thread src/FGraphDiff/mrob/factor_graph_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_graph_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp
Comment thread src/FGraphDiff/mrob/factor_graph_diff_solve.hpp Outdated
Comment thread src/pybind/FGraphDiffPy.cpp Outdated
Comment thread src/pybind/FGraphDiffPy.cpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp Outdated

@nosmokingsurfer nosmokingsurfer left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I will update file information comments, do clean up of EF methods adn etc and will remove redundant header includes where possible, but I have issues with headers in places where I do inheritance. In child class I need to include parent class header so the compiler can build object files for those classes. Linker works after all objects compiled - thus, compiler must know parent class declaration (method signature for example) to find them in corresponding parent object file.

Comment thread src/FGraphDiff/mrob/factor_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp Outdated
Comment thread src/FGraphDiff/CMakeLists.txt Outdated
Comment thread src/FGraphDiff/CMakeLists.txt Outdated
Comment thread src/FGraphDiff/examples/example_solver_2d.cpp Outdated
Comment thread src/FGraphDiff/mrob/factor_diff.hpp
Comment thread src/FGraphDiff/mrob/factor_graph_diff.hpp Outdated
Comment thread src/FGraphDiff/mrob/factor_graph_diff_solve.hpp Outdated
Comment thread src/pybind/FGraphDiffPy.cpp Outdated
Comment thread src/pybind/FGraphDiffPy.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants