fix: pixi-build-r recommended dependencies - #6924
Open
fhaefele wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pixi-build-rtreated R recommended packages as included inr-base. However, conda-forge buildsr-basewith [--with-recommended-packages=no] (https://github.com/conda-forge/r-base-feedstock/blob/main/recipe/build-r-base.sh#L208) and provides these packages as separater-*artifacts.This caused source builds to fail when their
DESCRIPTIONimported recommended packages. For example, NLRAA requiresboot,MASS,Matrix,mgcv, andnlme.R CMD INSTALLfailed because none were present in the build environment.This change keeps only
Priority: basepackages inR_BUILTIN_PACKAGES. Recommended packages now become normal host and run requirements:Base packages such as
statsremain excluded.Minimal reproduction:
Run:
Before this fix:
After this fix, Pixi resolves the separate conda-forge packages, builds NLRAA, and records the complete dependency graph in
pixi.lock.How Has This Been Tested?
Added a regression test using NLRAA's dependencies. It verifies that:
r-*host requirements.r-*run requirements.statsremain excluded.Commands:
pixi run cargo test -p pixi-build-r pixi run lintResults:
pixi-build-rtests passed.library(nlraa)succeeds.r-boot,r-mass,r-matrix,r-mgcv, andr-nlmeare resolved from conda-forge and recorded inpixi.lock.AI Disclosure
Tools: Codex, gpt-5.6-sol
Prompt:
Checklist: