fix(build): forward verbosity to build backends - #6806
Conversation
|
Update: the branch was rebased onto current This is ready for review whenever someone has bandwidth. |
84672d5 to
3c3655d
Compare
|
Hi maintainers, this PR has been rebased and all checks are passing. It has been ready for review for a little over a week. When someone has bandwidth, could you please take a look? I'm happy to address any feedback. Thanks! |
| } else { | ||
| 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
please can we make this generic over the installer? I think it can just be called verbosity and passed to pip the same as uv.
There was a problem hiding this comment.
Updated in 08cd4e3: the build script context now uses generic verbosity, and both uv and pip receive the same derived -v/-vv flags. Added pip coverage for default/debug/trace behavior.
| {%- if installer == "uv" and uv_verbosity == 1 -%} | ||
| {% set OPTIONS = ["-v"] + OPTIONS -%} | ||
| {%- elif installer == "uv" and uv_verbosity >= 2 -%} | ||
| {% set OPTIONS = ["-vv"] + OPTIONS -%} | ||
| {%- elif installer == "pip" -%} | ||
| {% set OPTIONS = ["-vv"] + OPTIONS -%} | ||
| {%- endif -%} |
There was a problem hiding this comment.
see other comment on having this be the same for all installers
There was a problem hiding this comment.
Handled in 08cd4e3 with the generic installer verbosity change.
3c3655d to
08cd4e3
Compare
2 participants
Description
Forward Pixi's effective CLI verbosity to JSON-RPC build backend processes without relying on process-global mutable state. Each command dispatcher snapshots immutable verbosity configuration, and both system and isolated tools receive matching backend flags. Existing public setup/command entry points keep their default behavior.
Also stop forcing uv's nested
pip installinvocation to-vvby default. The Python backend now derives uv verbosity from its backend logging level while preserving pip's existing-vvbehavior.Fixes #6099
How Has This Been Tested?
cargo test --locked --offline -p pixi_build_frontend -p pixi-build-pythonpixi_build_frontend: 7 passed; doc tests passedpixi-build-python: 96 passed; 1 ignoredcargo test --locked --offline -p pixi_command_dispatchercargo check --locked --offline -p pixi_clicargo clippy --locked --offline -p pixi_build_frontend -p pixi-build-python -p pixi_command_dispatcher -p pixi_cli --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkAI Disclosure
Tools: Codex
Prompt: Diagnose and fix #6099 using TDD; propagate Pixi CLI verbosity to build backends without global mutable state, preserve public APIs and pip behavior, add end-to-end regression coverage, and run the relevant Rust checks.
Checklist: