fix: use env variable for redux persist encryption key and fix localStorage.clear in logout (Batch-3) - #413
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs Fixed
1. Hardcoded encryption key in
store.tsThe Redux Persist encryption key was hardcoded as a string literal, with the env variable
VITE_REDUX_PERSIST_SECRET_KEYcommented out. This exposed the encryption key in the source code. Fixed by uncommenting the env variable and falling back to the hardcoded value only as a development default.2.
localStorage.clear()inauthSlice.tslogoutCalling
localStorage.clear()on logout wipes ALL locally stored data, including unrelated app state, user preferences, and cached data from other parts of the application. Fixed to only remove the Redux persist key instead of nuking the entire localStorage.