Repository navigation
Update logger tests for pony 0.77.0 - #367
Merged
Merged
Conversation
ponyc 0.77.0 errors on locals and parameters that shadow inherited methods. The four _StringLoggerTest subclasses named their `log` parameter `logger`, which shadows the `logger` method inherited from `_LoggerTest`. Rename to `logger'` to match the upstream logger 2.0.0 fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ponyc 0.77.0 errors on locals and parameters that shadow inherited methods. The four
_StringLoggerTestsubclasses named theirlogparameterlogger, which shadows theloggermethod inherited from_LoggerTest. Rename tologger'to match the upstream logger 2.0.0 fix.Also aligns the README's build-requirement wording with the ponyup convention.