Skip to content

mem(ncm): move USB-NCM tether RX copy to PSRAM (relieve internal SRAM) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iliabaranov wants to merge 1 commit into from
Closed

mem(ncm): move USB-NCM tether RX copy to PSRAM (relieve internal SRAM) #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions components/ml_dev_tether/src/ml_dev_tether.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <string.h>

#include "esp_event.h"
#include "esp_heap_caps.h"
#include "esp_log.h"
#include "esp_mac.h"
#include "esp_netif.h"
Expand Down Expand Up @@ -82,8 +83,14 @@ static esp_err_t on_usb_rx(void * buffer, uint16_t len, void * ctx)
esp_err_t r = ESP_OK;
if (n) {
/* lwIP takes ownership; we hand it its own buffer so tinyusb can
* recycle the original. */
void * copy = malloc(len);
* recycle the original. Allocate from PSRAM: this copy is filled by a
* plain CPU memcpy on the TinyUSB task (never DMA, never ISR — see the
* comment above) and consumed on the TCPIP thread, so the flash-cache-
* disable hazard does not apply. Keeping it off internal SRAM removes
* per-frame internal-heap alloc/free churn from the tether RX hot path
* (the device-side USB-NCM path, where internal RAM is scarcest).
* netif_l2_free()'s free() handles a PSRAM pointer unchanged. */
void * copy = heap_caps_malloc(len, MALLOC_CAP_SPIRAM | MALLOC_CAP_8BIT);
if (!copy) {
r = ESP_ERR_NO_MEM;
} else {
Expand Down
Loading